- [x] Fix typo: NodeCommu**u**nications: https://github.com/Multy-io/Multy-back/blob/53b57047fe98d885867d9db27fb6346199463e68/node-streamer/eth/streamer.proto#L5 - [ ] Remove unnecessary curly braces for rpc declaration https://github.com/Multy-io/Multy-back/blob/53b57047fe98d885867d9db27fb6346199463e68/node-streamer/eth/streamer.proto#L7-L8 - [ ] Remove unnecessary `Event` prefixes for rpc endpoints: https://github.com/Multy-io/Multy-back/blob/53b57047fe98d885867d9db27fb6346199463e68/node-streamer/eth/streamer.proto#L13 - [ ] Rename `AddressToResync` to address, 'cause it's just an address: https://github.com/Multy-io/Multy-back/blob/53b57047fe98d885867d9db27fb6346199463e68/node-streamer/eth/streamer.proto#L133-L135 - [ ] Remove reply info, 'cause gRPC returns golang errors https://github.com/Multy-io/Multy-back/blob/53b57047fe98d885867d9db27fb6346199463e68/node-streamer/eth/streamer.proto#L150-L155 - [ ] Remove unnecessary wallet info (`WalletIndex`, `WalletIndex`) from node service, it should be tracked on main, Multy-Back service: https://github.com/Multy-io/Multy-back/blob/53b57047fe98d885867d9db27fb6346199463e68/node-streamer/eth/streamer.proto#L145-L147 - [ ] Use [`Google.Protobuf.WellKnownTypes.Empty`](https://developers.google.com/protocol-buffers/docs/reference/csharp/class/google/protobuf/well-known-types/empty) instead of redeclaring `Empty` message - [ ] Use [protobuf style guide](https://developers.google.com/protocol-buffers/docs/style) for names - no CamelCase field names, only underscore_case
Multy-back/node-streamer/eth/streamer.proto
Line 5 in 53b5704
Multy-back/node-streamer/eth/streamer.proto
Lines 7 to 8 in 53b5704
Eventprefixes for rpc endpoints:Multy-back/node-streamer/eth/streamer.proto
Line 13 in 53b5704
AddressToResyncto address, 'cause it's just an address:Multy-back/node-streamer/eth/streamer.proto
Lines 133 to 135 in 53b5704
Multy-back/node-streamer/eth/streamer.proto
Lines 150 to 155 in 53b5704
WalletIndex,WalletIndex) from node service, it should be tracked on main, Multy-Back service:Multy-back/node-streamer/eth/streamer.proto
Lines 145 to 147 in 53b5704
Google.Protobuf.WellKnownTypes.Emptyinstead of redeclaringEmptymessage