Totally December Postround Tweaks (#852)

Author: MrMelbert

code/_onclick/hud/alert.dm

@@ -426,6 +426,7 @@ or shoot a gun to move around via Newton's 3rd Law of Motion."
 	if(!examinable)
 		return ..()
 
+	user.examine_feedback(offer.offered_item)
 	return list(
 		span_boldnotice(name),
 		span_info("[offer.owner] is offering you the following item (click the alert to take it!):"),

code/datums/quirks/negative_quirks/prosopagnosia.dm

@@ -35,23 +35,26 @@
 /datum/status_effect/grouped/see_no_names/proc/examine_name_override(datum/source, mob/living/carbon/human/examined, visible_name, list/name_override)
 	SIGNAL_HANDLER
 
-	if(!ishuman(examined) || source == examined)
+	if(!isliving(examined) || source == examined)
 		return NONE
+	if(!ishuman(examined) || !see_ids)
+		name_override[1] = "Unknown"
+		return COMPONENT_EXAMINE_NAME_OVERRIDEN
 
-	var/id_name =  see_ids && examined.get_id_name("", honorifics = TRUE)
+	var/id_name = examined.get_id_name("", honorifics = TRUE)
 	name_override[1] = id_name ? "[id_name]?" : "Unknown"
 	return COMPONENT_EXAMINE_NAME_OVERRIDEN
 
 /datum/status_effect/grouped/see_no_names/proc/screentip_name_override(datum/source, list/returned_name, obj/item/held_item, mob/living/carbon/human/hovered)
 	SIGNAL_HANDLER
 
-	if(!ishuman(hovered) || source == hovered)
+	if(!isliving(hovered) || source == hovered)
 		return NONE
-	if(!see_ids)
+	if(!ishuman(hovered) || !see_ids)
 		returned_name[1] = "Unknown"
 		return SCREENTIP_NAME_SET
 
-	var/id_name = see_ids && hovered.get_id_name("", honorifics = TRUE)
+	var/id_name = hovered.get_id_name("", honorifics = TRUE)
 	returned_name[1] = id_name ? "[id_name]?" : "Unknown"
 	return SCREENTIP_NAME_SET
 

code/game/atom/alternate_appearance.dm

@@ -178,16 +178,16 @@ GLOBAL_LIST_EMPTY(active_alternate_appearances)
 
 /datum/atom_hud/alternate_appearance/basic/food_demands
 
-/// Hud specifically used for humans when unconscious to hide other humans
-/datum/atom_hud/alternate_appearance/basic/human_unconscious_hud
+/// Hud specifically used for mobs when unconscious to hide other humans
+/datum/atom_hud/alternate_appearance/basic/unconscious_obscurity
 
-/datum/atom_hud/alternate_appearance/basic/human_unconscious_hud/New(key, image/I, options)
+/datum/atom_hud/alternate_appearance/basic/unconscious_obscurity/New(key, image/I, options)
 	. = ..()
 	RegisterSignal(target, COMSIG_LIVING_POST_UPDATE_TRANSFORM, PROC_REF(turn_image))
 
-/datum/atom_hud/alternate_appearance/basic/human_unconscious_hud/proc/turn_image(datum/source, ...)
+/datum/atom_hud/alternate_appearance/basic/unconscious_obscurity/proc/turn_image(datum/source, ...)
 	SIGNAL_HANDLER
 	image.transform = target.transform
 
-/datum/atom_hud/alternate_appearance/basic/human_unconscious_hud/mobShouldSee(mob/M)
+/datum/atom_hud/alternate_appearance/basic/unconscious_obscurity/mobShouldSee(mob/M)
 	return FALSE // this hud is managed manually, so don't show it generically

code/modules/mob/living/basic/revolutionary.dm

@@ -108,6 +108,8 @@
 	shuffle_inplace(causes)
 	desc += span_notice("#[pick(causes)].")
 
+/mob/living/basic/revolutionary/init_unconscious_appearance()
+	add_generic_humanoid_static_appearance()
 
 /obj/effect/mob_spawn/corpse/human/revolutionary
 	name = "Revolutionary"

code/modules/mob/living/basic/ruin_defender/skeleton.dm

@@ -56,6 +56,9 @@
 	var/list/foods_list = good_drinks + bad_drinks
 	ai_controller?.set_blackboard_key(BB_BASIC_FOODS, typecacheof(foods_list))
 
+/mob/living/basic/skeleton/init_unconscious_appearance()
+	add_generic_humanoid_static_appearance()
+
 /mob/living/basic/skeleton/settler
 	name = "undead settler"
 	desc = "The reanimated remains of some poor settler."

code/modules/mob/living/basic/ruin_defender/wizard/wizard.dm

@@ -90,6 +90,9 @@
 		fake_blood_type = random_human_blood_type()
 	return find_blood_type(fake_blood_type)
 
+/mob/living/basic/wizard/init_unconscious_appearance()
+	add_generic_humanoid_static_appearance()
+
 /// Uses the colors and loadout of the original wizard simplemob
 /mob/living/basic/wizard/classic
 	selected_outfit = /obj/effect/mob_spawn/corpse/human/wizard

code/modules/mob/living/basic/space_fauna/cat_surgeon.dm

@@ -51,6 +51,9 @@
 		fake_blood_type = random_human_blood_type()
 	return find_blood_type(fake_blood_type)
 
+/mob/living/basic/cat_butcherer/init_unconscious_appearance()
+	add_generic_humanoid_static_appearance()
+
 /mob/living/basic/cat_butcherer/proc/after_attack(mob/living/basic/attacker, atom/target)
 	SIGNAL_HANDLER
 

code/modules/mob/living/basic/space_fauna/paper_wizard/paper_wizard.dm

@@ -35,6 +35,9 @@
 	grant_loot()
 	AddElement(/datum/element/effect_trail, /obj/effect/temp_visual/paper_scatter)
 
+/mob/living/basic/paper_wizard/init_unconscious_appearance()
+	add_generic_humanoid_static_appearance()
+
 /mob/living/basic/paper_wizard/proc/grant_abilities()
 	var/static/list/innate_actions = list(
 		/datum/action/cooldown/spell/conjure/wizard_summon_minions = BB_WIZARD_SUMMON_MINIONS,
@@ -175,4 +178,3 @@
 	new /obj/effect/temp_visual/paper_scatter(current_turf)
 	new /obj/item/clothing/suit/wizrobe/paper(current_turf)
 	new /obj/item/clothing/head/collectable/paper(current_turf)
-

code/modules/mob/living/basic/trader/trader.dm

@@ -58,6 +58,9 @@
 	setup_shop.Grant(src)
 	ai_controller.set_blackboard_key(BB_SETUP_SHOP, setup_shop)
 
+/mob/living/basic/trader/init_unconscious_appearance()
+	add_generic_humanoid_static_appearance()
+
 /mob/living/basic/trader/mrbones
 	name = "Mr. Bones"
 	desc = "A skeleton merchant, he seems very humerus."

code/modules/mob/living/basic/trooper/trooper.dm

@@ -44,3 +44,6 @@
 	if(!fake_blood_type)
 		fake_blood_type = random_human_blood_type()
 	return find_blood_type(fake_blood_type)
+
+/mob/living/basic/trooper/init_unconscious_appearance()
+	add_generic_humanoid_static_appearance()