fix: polish goal lifecycle messaging#555
Conversation
🦋 Changeset detectedLatest commit: c539c39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b39226e2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex Please review. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
# Conflicts: # apps/kimi-code/src/tui/controllers/session-event-handler.ts # apps/kimi-code/src/tui/controllers/session-replay.ts # apps/kimi-code/src/tui/utils/goal-completion.ts # apps/kimi-code/test/tui/utils/goal-completion.test.ts # packages/agent-core/src/agent/goal/index.ts # packages/agent-core/src/agent/records/index.ts # packages/agent-core/src/agent/turn/index.ts # packages/agent-core/src/rpc/resumed.ts # packages/agent-core/src/tools/builtin/goal/update-goal.ts # packages/agent-core/test/harness/goal-session.test.ts # packages/agent-core/test/tools/goal.test.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3fbc1abd0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
To use Codex here, create a Codex account and connect to github. |
# Conflicts: # packages/agent-core/test/harness/goal-session.test.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d63de2ab39
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
Related Issue
No linked issue. This PR fixes follow-up issues found while reviewing goal-mode transcripts and outcome messaging.
Problem
Goal-mode status changes and outcome follow-ups were hard to scan:
What changed
CreateGoal,GetGoal,SetGoalBudget, andUpdateGoal.UpdateGoal(complete)orUpdateGoal(blocked)so the agent writes a user-facing completion summary or blocker reason.Checklist
Verification
pnpm vitest run packages/agent-core/test/agent/goal-completion.test.ts packages/agent-core/test/harness/goal-session.test.ts apps/kimi-code/test/tui/components/messages/goal-panel.test.ts apps/kimi-code/test/tui/message-replay.test.tspnpm --filter @moonshot-ai/agent-core run typecheckpnpm --filter @moonshot-ai/kimi-code run typecheckpnpm --filter kimi-code-docs run buildgit diff --check origin/main...HEAD