Merge pull request #218 from bkabrda/master

Raise ValueError if Mongo host URI is given and it doesn't contain DB name

Author: losintikfos

flask_mongoengine/__init__.py

@@ -92,6 +92,8 @@ def _create_connection(conn_settings):
     elif "://" in conn.get('host', ''):
         uri_dict = uri_parser.parse_uri(conn['host'])
         conn['db'] = uri_dict['database']
+        if conn['db'] is None:
+            raise ValueError('Mongo host URI must contain database name')
 
     return mongoengine.connect(conn.pop('db', 'test'), **conn)
 

tests/test_connection.py

@@ -32,5 +32,11 @@ def test_parse_uri_if_testing_not_true(self):
 
         self.assertRaises(InvalidURI, MongoEngine, self.app)
 
+    def test_parse_uri_without_database_name(self):
+        self.app.config['TESTING'] = False
+        self.app.config['MONGODB_HOST'] = 'mongodb://localhost'
+
+        self.assertRaises(ValueError, MongoEngine, self.app)
+
 if __name__ == '__main__':
     unittest.main()