Skip to content

Commit a28d610

Browse files
committed
Resolving "False is not a read preference".
1 parent bf25478 commit a28d610

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

flask_mongoengine/connection.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
)
1414

1515
DEFAULT_CONNECTION_NAME = 'default-mongodb-connection'
16+
IS_PYMONGO_3 = (pymongo.version_tuple[0] < 3)
17+
if IS_PYMONGO_3:
18+
READ_PREFERENCE = ReadPreference.PRIMARY
19+
else: READ_PREFERENCE = False
1620

1721
_connection_settings = {}
1822
_connections = {}
@@ -240,7 +244,6 @@ def _register_test_connection(port, db_alias, preserved):
240244
def _resolve_settings(conn_setting, removePass=True):
241245

242246
if conn_setting and isinstance(conn_setting, dict):
243-
read_preference = False
244247
alias = conn_setting.get('MONGODB_ALIAS',
245248
conn_setting.get('alias', DEFAULT_CONNECTION_NAME))
246249
db = conn_setting.get('MONGODB_DB', conn_setting.get('db', 'test'))
@@ -249,8 +252,8 @@ def _resolve_settings(conn_setting, removePass=True):
249252
username = conn_setting.get('MONGODB_USERNAME', conn_setting.get('username', None))
250253
password = conn_setting.get('MONGODB_PASSWORD', conn_setting.get('password', None))
251254

252-
if pymongo.version_tuple[0] < 3:
253-
read_preference = ReadPreference.PRIMARY
255+
read_preference = conn_setting.get('MONGODB_READ_PREFERENCE',
256+
conn_setting.get('read_preference', READ_PREFERENCE))
254257

255258
resolved = {}
256259
resolved['read_preference'] = read_preference

0 commit comments

Comments
 (0)