Skip to content

Commit 8ae1fb8

Browse files
committed
Merge pull request #212 from Nobatek/dev_JL_cleanup_ME_0_7
ME 0.7 removal cleanup
2 parents db19e5d + ec5d867 commit 8ae1fb8

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

flask_mongoengine/__init__.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@
77
import mongoengine
88
from distutils.version import StrictVersion
99

10-
if mongoengine.__version__ == '0.7.10':
11-
from mongoengine.base import BaseField
12-
else:
13-
from mongoengine.base.fields import BaseField
10+
from mongoengine.base.fields import BaseField
1411

1512

1613
from mongoengine.queryset import MultipleObjectsReturned, DoesNotExist, QuerySet
@@ -21,7 +18,7 @@
2118
from .sessions import *
2219
from .pagination import *
2320
from .metadata import *
24-
from .json import overide_json_encoder
21+
from .json import override_json_encoder
2522
from .wtf import WtfBaseField
2623

2724
def _patch_base_field(object, name):
@@ -116,7 +113,7 @@ def init_app(self, app, config=None):
116113
app.extensions = getattr(app, 'extensions', {})
117114

118115
# Make documents JSON serializable
119-
overide_json_encoder(app)
116+
override_json_encoder(app)
120117

121118
if not 'mongoengine' in app.extensions:
122119
app.extensions['mongoengine'] = {}

flask_mongoengine/json.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
from flask.json import JSONEncoder
22
from bson import json_util
33
from mongoengine.base import BaseDocument
4-
try:
5-
from mongoengine.base import BaseQuerySet
6-
except ImportError as ie: # support mongoengine < 0.7
7-
from mongoengine.queryset import QuerySet as BaseQuerySet
4+
from mongoengine.queryset import QuerySet
5+
86

97
def _make_encoder(superclass):
108
class MongoEngineJSONEncoder(superclass):
@@ -15,15 +13,15 @@ class MongoEngineJSONEncoder(superclass):
1513
def default(self, obj):
1614
if isinstance(obj, BaseDocument):
1715
return json_util._json_convert(obj.to_mongo())
18-
elif isinstance(obj, BaseQuerySet):
16+
elif isinstance(obj, QuerySet):
1917
return json_util._json_convert(obj.as_pymongo())
2018
return superclass.default(self, obj)
2119
return MongoEngineJSONEncoder
2220

2321
MongoEngineJSONEncoder = _make_encoder(JSONEncoder)
2422

2523

26-
def overide_json_encoder(app):
24+
def override_json_encoder(app):
2725
'''
2826
A function to dynamically create a new MongoEngineJSONEncoder class
2927
based upon a custom base class.

flask_mongoengine/pagination.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ def __init__(self, queryset, doc_id, field_name, page, per_page,
145145

146146
field_attrs = {field_name: {"$slice": [start_index, per_page]}}
147147

148-
# Clone for mongoengine 0.7
149148
qs = queryset(pk=doc_id)
150149
self.items = getattr(qs.fields(**field_attrs).first(), field_name)
151150
self.total = total or len(getattr(qs.fields(**{field_name: 1}).first(),

0 commit comments

Comments
 (0)