Skip to content

Commit 0c25fe7

Browse files
committed
Resolving issue the replicaSet keyword parameter is required.
1 parent 991ab61 commit 0c25fe7

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

flask_mongoengine/connection.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@
1313
)
1414

1515
DEFAULT_CONNECTION_NAME = 'default-mongodb-connection'
16-
if pymongo.version_tuple[0] < 3:
17-
IS_PYMONGO_3 = False
18-
else:
19-
IS_PYMONGO_3 = True
2016

2117
_connection_settings = {}
2218
_connections = {}
@@ -253,18 +249,19 @@ def _resolve_settings(conn_setting, removePass=True):
253249
username = conn_setting.get('MONGODB_USERNAME', conn_setting.get('username', None))
254250
password = conn_setting.get('MONGODB_PASSWORD', conn_setting.get('password', None))
255251

256-
if IS_PYMONGO_3:
252+
if pymongo.version_tuple[0] < 3:
257253
read_preference = ReadPreference.PRIMARY
258254

259255
resolved = {}
260256
resolved['read_preference'] = read_preference
261257
resolved['alias'] = alias
262-
resolved['name'] = db
263-
resolved['host'] = host
264-
resolved['password'] = password
265-
resolved['port'] = port
266-
resolved['username'] = username
267-
resolved['replicaSet'] = conn_setting.pop('replicaset', None)
258+
if db: resolved['name'] = db
259+
if host: resolved['host'] = host
260+
if password: resolved['password'] = password
261+
if port: resolved['port'] = port
262+
if username: resolved['username'] = username
263+
if conn_setting.pop('replicaset', None):
264+
resolved['replicaSet'] = conn_setting.pop('replicaset', None)
268265

269266
host = resolved['host']
270267
# Handle uri style connections

0 commit comments

Comments
 (0)