Skip to content

Fix current ESLint failures #7

@MoerAI

Description

@MoerAI

Summary

npm run lint currently fails on the public repository. Build and TypeScript diagnostics pass, but lint should be clean for a public project and future CI.

Evidence

Manual command run in /tmp/ngtt-export:

npm run lint

Reported failures:

  • src/app/(auth)/login/page.tsx:123react/no-unescaped-entities for Don't.
  • src/app/(main)/reviewer/page.tsx:55react-hooks/set-state-in-effect for synchronous setLoading(false) inside effect.
  • src/app/(main)/worker/tasks/[taskId]/page.tsx:52react-hooks/set-state-in-effect for synchronous setWriteValues(...) inside effect.
  • src/app/(main)/worker/tasks/[taskId]/page.tsx:54 — missing currentRow dependency warning.
  • src/app/(main)/layout.tsx:9 — unused roleInfo warning.
  • src/app/(main)/reviewer/tasks/[taskId]/page.tsx:9 — unused Label warning.

Impact

Lint failures make it harder to add CI, hide real regressions, and signal that the public repo is not in a clean maintainable state.

Minimal Fix

  • Escape the apostrophe in login copy or use a safe string expression.
  • Refactor state initialization in reviewer/worker pages to avoid synchronous setState-in-effect patterns or justify/disable with a local comment only if truly unavoidable.
  • Remove unused imports/variables.
  • Re-run lint after changes.

Acceptance Criteria

  • npm run lint exits 0.
  • npm run build still exits 0.
  • No broad lint rule disables are added.

Metadata

Metadata

Assignees

No one assigned

    Labels

    lintLint/type/code quality issuepriority: highHigh priority remediation

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions