metrics

Author: flesher0813

ucm/shared/metrics/cc/metrics.cc

@@ -35,8 +35,8 @@ void Metrics::CreateStats(const std::string& name, std::string& type)
     } else {
         if (type == "COUNTER") {
             stats_type_[name] = MetricType::COUNTER;
-        } else if (type == "GUAGE") {
-            stats_type_[name] = MetricType::GUAGE;
+        } else if (type == "GAUGE") {
+            stats_type_[name] = MetricType::GAUGE;
         } else if (type == "HISTOGRAM") {
             stats_type_[name] = MetricType::HISTOGRAM;
         } else {
@@ -49,13 +49,13 @@ void Metrics::UpdateStats(const std::string& name, double value)
 {
     std::lock_guard<std::mutex> lock(mutex_);
     auto it = stats_type_.find(name);
-    if (it == stats_map_.end() || !it->second) { return; }
+    if (it == stats_type_.end()) { return; }
     switch (it->second)
     {
     case MetricType::COUNTER:
         counter_stats_[name] += value;
         break;
-    case MetricType::GUAGE:
+    case MetricType::GAUGE:
         gauge_stats_[name] = value;
         break;
     case MetricType::HISTOGRAM:

ucm/shared/metrics/cc/metrics.h

@@ -54,13 +54,13 @@ class Metrics {
     > GetAllStatsAndClear();
 
 private:
-    enum class MetricType { COUNTER, GUAGE, HISTOGRAM };
+    enum class MetricType { COUNTER, GAUGE, HISTOGRAM };
 
     std::mutex mutex_;
     std::unordered_map<std::string, double> counter_stats_;
     std::unordered_map<std::string, double> gauge_stats_;
     std::unordered_map<std::string, std::vector<double>> histogram_stats_;
-    std::unordered_map<std::string, int> stats_type_;
+    std::unordered_map<std::string, MetricType> stats_type_;
 
     Metrics() = default;
     Metrics(const Metrics&) = delete;

ucm/shared/metrics/cpy/metrics.py.cc

@@ -36,7 +36,11 @@ inline void UpdateStats(const std::string& name, double value) {
     Metrics::GetInstance().UpdateStats(name, value);
 }
 
-inline auto GetAllStatsAndClear() {
+inline std::tuple<
+    std::unordered_map<std::string, double>,
+    std::unordered_map<std::string, double>,
+    std::unordered_map<std::string, std::vector<double>>
+> GetAllStatsAndClear() {
     return Metrics::GetInstance().GetAllStatsAndClear();
 }
 
@@ -49,7 +53,7 @@ void bind_monitor(py::module_& m)
 
 } // namespace UC::Metrics
 
-PYBIND11_MODULE(ucmmonitor, module)
+PYBIND11_MODULE(ucmmetrics, module)
 {
     module.attr("project") = UCM_PROJECT_NAME;
     module.attr("version") = UCM_PROJECT_VERSION;