Add notice for agency_id

[Orkunnnn]

Describe the problem

agency_id is a conditionally required field, and there is no missing_agency_id notice for it. stop_name is also a conditionally required field, and it has its own missing_stop_name notice. Wouldn’t it make sense to have a similar notice for agency_id as well?

Describe the new validation rule

If:
(number_of_agencies > 1) AND (agency_id = '' OR agency_id is missing):
trigger a missing_agency_id notice

Sample GTFS datasets

No response

Severity

ERROR

Additional context

No response

[welcome]

Thanks for opening your first issue in this project! If you haven't already, you can join our slack and join the #gtfs-validators channel to meet our awesome community. Come say hi 👋!

Welcome to the community and thank you for your engagement in open source! 🎉

[skalexch]

Thank you for opening this issue @Orkunnnn. I'll add the notice requirement table.

Notice Requirements

Related spec language	Rationale for rule	Notice name to update or add	Pseudologic	Notice table columns	Severity	Notice description
agency.agency_id, routes.agency_id, fare_attributes.agency_id	agency.agency_id, routes.agency_id or fare_attributes.agency_id` is required when there are multiple agencies.	missing_required_agency	If (number_of_agencies > 1):   For filename in (agency.txt, routes.txt, fare_attributes.txt):    If agency_id = '' OR agency_id is missing: Trigger	filename (agency.txt, routes.txt or fare_attributes.txt), csvRowNumber, agencyName	ERROR	agency.agency_id, routes.agency_id or fare_attributes.agency_id is required when there are multiple agencies.

@emmambd should we also remove the check from missing_required_field since it will have its own notice? Or is that done automatically?

[emmambd]

@skalexch I think @Orkunnnn is pointing out that since agency_id is conditionally required, this is a gap in missing_required_field, unless your investigation showed otherwise, Skander.

[skalexch]

@emmambd you're right. I will also update the logic. agency_id becomes required in agency.txt, routes.txt and fare_attributes.txt

[jcpitre]

@skalexch For the Notice table columns there will be no agencyName if there is no agencyId, except maybe for the agency table itself that could have an agencyName while having no agencyId.
That means that most notices will have an empty agencyName.

[skalexch]

@jcpitre agency_name is a required field, and agency.txt is a required file. So there should be an agency name all the time. Otherwise there will be a missing_required_field notice.

[jcpitre]

But this notice is about missing agency IDs, so we can't get the agency name since we don't know the agency id (for the routes.txt and fare_attributes.txt records)
Except maybe for agency.txt that could have no agency id but have an agency name.

[skalexch]

@jcpitre you're right. I think in that case, the row and filename are the only outputs.

[jcpitre]

@skalexch I am thinking the notice should be called missing_required_agency_id, since it's the id that's missing.
What do you think?

[skalexch]

@jcpitre I second that change 👍