Invalid code generated by MSBuilder.ThisAssembly.Vsix

[mhutch]

I added MSBuilder.ThisAssembly.Vsix 0.1.8 to a VSIX project, and the generated ThisAssembly.Vsix.g.cs started with invalid C#:

#define GLOBALNAMESPACE
#define 
#pragma warning disable 0436

[mhutch]

I added a GitInfo reference - looks like a missing dependency - but it didn't regen the file, even when i cleaned. I had to manually delete the file to get it to regen.

[mhutch]

And then the ThisAssembly class ends up conflicting with an internal ThisAssembly class in Microsoft.VisualStudio.Composition

[mhutch]

Would it maybe be better to default ThisAssemblyNamespace to RootNamespace?

[mhutch]

looks like the last issue was some kind of roslyn typesystem caching. global worked fine after dirtying the project.

[kzu]

Heya @mhutch, sorry I missed this. The "conflict" with other internal ThisAssembly classes is kinda expected. Many assemblies use this type name for sharing this kind of data.

Also, not defaulting the namespace to RootNamespace is also sort of by design, since that's also the way most other libraries do it (using no namespace at all).

Finally, I'm not using this much lately, and just relying on MSBuild props injected into the VSIX manifest instead using the token replacement syntax (like |MyProject.Vsix;GetVsixVersion|) instead. Potentially combined with the https://github.com/MobileEssentials/MSBuilder/tree/master/src/ThisAssembly.Metadata