feat(google-places): source API key from MP config first, env var as fallback#14
Merged
Merged
Conversation
…fallback Reworks GooglePlacesService key resolution to prefer the dp_Configuration_Settings row (Application_Code='COMMON', Key_Name='GoogleMapsAPIKey') before falling back to the GOOGLE_PLACES_API_KEY environment variable. When neither is set the feature stays disabled and the address autocomplete UI falls back to a plain text input as before. - Service now holds an MPHelper and a resolveApiKey() helper that caches the lookup on the singleton (MP is queried at most once per process). - isEnabled() and getProvider() are now async; MP lookup failures are swallowed so a permissions issue does not break the env-var fallback. - Updates the one synchronous caller in addeditfamily/actions.ts. - Documents the new precedence order in .env.example. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GooglePlacesServicenow resolves the API key fromdp_Configuration_Settings(Application_Code='COMMON',Key_Name='GoogleMapsAPIKey') before falling back toGOOGLE_PLACES_API_KEY. If neither is set, the feature stays disabled exactly as before.isEnabled()andgetProvider()are now async; the single sync caller inaddeditfamily/actions.tswas updated..env.exampledocuments the new precedence.Test plan
dp_Configuration_Settings.ValueforApplication_Code='COMMON'/Key_Name='GoogleMapsAPIKey'and confirm the Add/Edit Family address autocomplete works with that key (and not the env var).GOOGLE_PLACES_API_KEYset in.env.local, confirm autocomplete still works (env-var fallback).dp_Configuration_Settings).🤖 Generated with Claude Code