Edit text with embedded images

[JhnW]

Hi.
I tested the plugin on NodeBB v3.7.1. On this version, the plugin goes a bit crazy when I create a response with an embedded image:

• The image cannot be centered.
• After posting an image, other formatting also seems to not work, e.g. spoiler.
• Some things, such as spoilers, can be bypassed by creating a spoiler first, and then adding the content to the image.
• When you upload an image, the text alignments don't work very well either.

The mentioned effects appear not only in the preview but also the final effect is just as disappointing.

Please let me know what your plan is for fixes in this regard. Ultimately, over the course of a few or a dozen or so months, I can try to repair the plugin myself or try to delegate someone from my team (we are a non-commercial RPG forum).

[robin4002]

Hello,

The root cause seems to be the same as in #11

This example will work :

|-![Capture d'écran 2024-02-14 094702.png](/assets/uploads/files/1712086237880-capture-d-x27-écran-2024-02-14-094702.png)
Centered text-|

And example this also work :

|-![Capture d'écran 2024-02-14 094702.png](/assets/uploads/files/1712086237880-capture-d-x27-écran-2024-02-14-094702.png)-|

|-Centered text-|

But not this one (interpreted as "left for the image, right for the text") :

|-![Capture d'écran 2024-02-14 094702.png](/assets/uploads/files/1712086237880-capture-d-x27-écran-2024-02-14-094702.png)

Centered text-|

I also tested spoiler with text align, actually it doesn't work.

Fixing this will require changing the approach used to add text align, unfortunately I don't have time for that.
Currently, I use a regex to detect |- -| and to add the according align-xxx to the class of the p or h1, h2, etc. element. I keep the existing DOM, I only add classes to it. To address this issue, it will be necessary to cut the current DOM and add new parents to some elements, which seems much more complex.