Fix tests and add more

Author: joshooaj

.github/workflows/CI.yaml

@@ -1,7 +1,10 @@
 name: CI
-#on: [push, pull_request]
+
 on:
+  push:
+  pull_request:
   workflow_dispatch:
+
 jobs:
   test:
     name: Run Tests

.github/workflows/test.yaml

@@ -1 +1,18 @@
-# No content - module is "compiled" during build and all functions are copied here at that time.
+# Only dot-source files at development time. At build time, all classes and functions are embedded in the PSM1 file.
+if (Get-ChildItem $PSScriptRoot\Classes\*.ps1 -ErrorAction SilentlyContinue) {
+    [object[]]$classes = Get-ChildItem $PSScriptRoot\Classes\*.ps1
+    [object[]]$private = Get-ChildItem $PSScriptRoot\Private\*.ps1
+    [object[]]$public = Get-ChildItem $PSScriptRoot\Public\*.ps1
+    $classes, $private, $public | ForEach-Object {
+        $_ | ForEach-Object {
+            $file = $_
+            try {
+                . $file
+            } catch {
+                Write-Warning "Failed to dot-source $($file.FullName): $_"
+                throw
+            }
+        }
+    }
+    Export-ModuleMember -Function $public.BaseName
+}

MilestoneSystems.PowerShell.MediaDB/MilestoneSystems.PowerShell.MediaDB.psm1

@@ -54,7 +54,8 @@ function Open-MediaDatabase {
             "file:\$DatabasePath"
         )
     } catch {
-        Close-MediaDatabase -LiteralPath $DatabasePath
+        # Must remove all servers - removing just the one that failed to open will throw UriFormatException
+        [videoos.platform.sdk.environment]::RemoveAllServers()
         throw
     }
 }

MilestoneSystems.PowerShell.MediaDB/Public/Open-MediaDatabase.ps1

@@ -7,10 +7,14 @@ properties {
 
     $psake.context.tasks.stagefiles.PostAction = {
         $outputManifestPath = [io.path]::Combine($PSBPreference.Build.ModuleOutDir, "$($PSBPreference.General.ModuleName).psd1")
-        Write-Host "Updating ModuleVersion in output manifest '$outputManifestPath' to NBGV-based version $($PSBPreference.General.ModuleVersion)"
-        BuildHelpers\Update-Metadata -Path $outputManifestPath -Property ModuleVersion -Value $PSBPreference.General.ModuleVersion
-        #$content = Get-Content $outputManifestPath | ForEach-Object { $_ -replace "'0.1.0'", "'$($PSBPreference.General.ModuleVersion)'" }
-        #$content | Set-Content $outputManifestPath -Encoding UTF8
+        Write-Verbose "Updating ModuleVersion in output manifest '$outputManifestPath' to NBGV-based version $($PSBPreference.General.ModuleVersion)"
+
+        if (Get-Module MilestonePSTools) {
+            # Unload the MilestonePSTools module due to conflicting Get-Metadata command
+            Remove-Module MilestonePSTools -Force
+        }
+
+        Update-Metadata -Path $outputManifestPath -Value $PSBPreference.General.ModuleVersion
 
         Write-Verbose "Converting root module to UTF8 since PowerShellBuild generates a Unicode file on Windows PowerShell"
         Import-Module (Join-Path $env:BHProjectPath 'tests/MetaFixers.psm1')

psakeFile.ps1

@@ -0,0 +1,29 @@
+Context "Export-Mdb" {
+    BeforeAll {
+        $script:EncryptedDbPath = [io.path]::Combine($PSScriptRoot, 'data', 'EncryptedExport', 'cache.xml')
+        $script:UnencryptedDbPath = [io.path]::Combine($PSScriptRoot, 'data', 'UnencryptedExport', 'cache.xml')
+    }
+
+    AfterEach {
+        Close-MediaDatabase
+    }
+
+    It "Can export from encrypted database" {
+        $password = 'rzxW&s3Ftw' | ConvertTo-SecureString -AsPlainText -Force
+        Open-MediaDatabase -Path $script:EncryptedDbPath -Password $password
+
+        $folder = Get-MdbCamera | Get-MdbSequence -Type RecordingSequence | ForEach-Object {
+            $item = [videoos.platform.configuration]::Instance.GetItem($_.FQID)
+            $path = 'TestDrive:\{0}_{1}_Database' -f $_.Source, $_.Start.ToString('yyyy-MM-dd_HH-mm-ss')
+            $exportParams = @{
+                Device = $item
+                Start  = $_.Start
+                End    = $_.End
+                Path   = $path
+            }
+            Export-Mdb @exportParams
+        }
+        $folder | Should -Not -BeNullOrEmpty
+        (Test-Path $folder -PathType Container) | Should -Be $true
+    }
+}

tests/Export-Mdb.tests.ps1

@@ -0,0 +1,28 @@
+Context "Export-MdbMkv" {
+    BeforeAll {
+        $script:EncryptedDbPath = [io.path]::Combine($PSScriptRoot, 'data', 'EncryptedExport', 'cache.xml')
+        $script:UnencryptedDbPath = [io.path]::Combine($PSScriptRoot, 'data', 'UnencryptedExport', 'cache.xml')
+    }
+
+    AfterEach {
+        Close-MediaDatabase
+    }
+
+    It "Can export from encrypted database" {
+        $password = 'rzxW&s3Ftw' | ConvertTo-SecureString -AsPlainText -Force
+        Open-MediaDatabase -Path $script:EncryptedDbPath -Password $password
+
+        $mkvFile = Get-MdbCamera | Get-MdbSequence -Type RecordingSequence | ForEach-Object {
+            $item = [videoos.platform.configuration]::Instance.GetItem($_.FQID)
+            $path = 'TestDrive:\{0}_{1}.mkv' -f $_.Source, $_.Start.ToString('yyyy-MM-dd_HH-mm-ss')
+            $exportParams = @{
+                Device = $item
+                Start  = $_.Start
+                End    = $_.End
+                Path   = $path
+            }
+            Export-MdbMkv @exportParams
+        }
+        $mkvFile | Should -Not -BeNullOrEmpty
+    }
+}

tests/Export-MdbMkv.tests.ps1

@@ -0,0 +1,33 @@
+Context "Open-MediaDatabase" {
+    BeforeAll {
+        $script:EncryptedDbPath = [io.path]::Combine($PSScriptRoot, 'data', 'EncryptedExport', 'cache.xml')
+        $script:UnencryptedDbPath = [io.path]::Combine($PSScriptRoot, 'data', 'UnencryptedExport', 'cache.xml')
+    }
+
+    AfterEach {
+        Close-MediaDatabase
+    }
+
+    It "Can open encrypted database" {
+        $password = 'rzxW&s3Ftw' | ConvertTo-SecureString -AsPlainText -Force
+        Open-MediaDatabase -Path $script:EncryptedDbPath -Password $password
+        $cameras = Get-MdbCamera
+        $cameras.Count | Should -BeExactly 2
+    }
+
+    It "Can open unencrypted database" {
+        Open-MediaDatabase -Path $script:UnencryptedDbPath
+        $cameras = Get-MdbCamera
+        $cameras.Count | Should -BeExactly 2
+    }
+
+    It "Throws expected error with incorrect password" {
+        try {
+            $password = 'wrong-password' | ConvertTo-SecureString -AsPlainText -Force
+            Open-MediaDatabase -Path $script:EncryptedDbPath -Password $password
+        } catch {
+            $exception = $_.Exception.InnerException
+        }
+        $exception | Should -BeOfType ([VideoOS.Platform.NotAuthorizedMIPException])
+    }
+}

tests/Open-MediaDatabase.tests.ps1

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8" standalone="yes"?>
+<BookmarkExport version="1.0" deviceid="e227d322-9fba-426a-92bc-7e05290eda00" begintime="2025-02-27T21:37:56.6135067Z" endtime="2025-02-27T21:38:57.4488977Z">
+  <Bookmarks />
+</BookmarkExport>

tests/data/EncryptedExport/Bookmarks.xml

@@ -1,12 +1,11 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<bank version="1.2">
-    <description>Shoe Store</description>
-    <encryption>
-        <algorithm>AES</algorithm>
-        <size_to_encrypt>0</size_to_encrypt>
-        <password_selection>1</password_selection>
-    </encryption>
-    <meta_data>
-        <entry key="device_type">Camera</entry>
-    </meta_data>
-</bank>
+<?xml version="1.0" encoding="UTF-8" standalone="no" ?>    <bank version="1.2">
+            <description>Shoe Store</description>
+            <encryption>
+                <algorithm>AES</algorithm>
+                <size_to_encrypt>0</size_to_encrypt>
+                <password_selection>1</password_selection>
+            </encryption>
+            <meta_data>
+                <entry key="device_type">Camera</entry>
+            </meta_data>
+    </bank>