🧹 Refactor mermaid installation to consolidate package manager logic#234
Conversation
…n logic Refactored `src/mermaid/install.sh` to eliminate redundant OS-specific package installation logic. Introduced `pkg_install` and `pkg_cleanup` helper functions to abstract package manager commands across supported OS families (Debian, Ubuntu, Fedora, CentOS, RHEL, Alpine, openSUSE, SLES). Simplified `install_dependencies`, `install_nodejs`, and `cleanup` functions to use these new helpers, improving readability and maintainability. Co-authored-by: MiguelRodo <23501332+MiguelRodo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Consolidatd OS-specific package manager commands into reusable helper functions in
src/mermaid/install.sh.💡 Why: Extraction of the OS package manager command execution into a helper function prevents duplicating large case statements for every tool install, improving maintainability and following DRY principles.
✅ Verification:
bash -n src/mermaid/install.sh.✨ Result: Improved script readability and easier maintenance for future package additions or OS support.
PR created automatically by Jules for task 9307230667019660264 started by @MiguelRodo