🧪 [testing improvement] Add isolated tests for get_elevated_token and get_best_token#233
Conversation
This commit adds a new integration test script `test/_global/github-tokens-functions.sh` that thoroughly exercises the `get_best_token` and `get_elevated_token` functions in `src/github-tokens/cmd/github-pat`. The tests use subshells to isolate environment variables and verify the priority and fallback logic for GITHUB_PAT, GH_TOKEN, and GITHUB_TOKEN. A new scenario `github-tokens-functions` has been added to `test/_global/scenarios.json` to include these tests in the global test suite. Co-authored-by: MiguelRodo <23501332+MiguelRodo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The testing gap addressed
The
get_elevated_tokenandget_best_tokenfunctions in thegithub-patscript were previously untested in isolation. These functions are critical for determining which authentication token to use, following a specific priority order.📊 Coverage: What scenarios are now tested
The new
github-tokens-functionsscenario covers:GITHUB_PAT > GH_TOKEN > GITHUB_TOKEN.GITHUB_PAT > GH_TOKENand ensures it correctly falls back to empty if onlyGITHUB_TOKENis set.✨ Result: The improvement in test coverage
By adding these isolated functional tests, we ensure that the core token selection logic is robust and won't regress when the script is refactored or updated. The tests use subshell isolation to prevent environment leakage between test cases.
PR created automatically by Jules for task 16027632828497331161 started by @MiguelRodo