🧪 [test] Add test coverage for invalid USERNAME validation in Mermaid feature#227
Conversation
Added `test/_global/mermaid_invalid_user.sh` to explicitly test the error path in `src/mermaid/install.sh` when an invalid `USERNAME` format is provided. This test script runs the install script directly with a bad username and asserts the script fails with the expected error output. Co-authored-by: MiguelRodo <23501332+MiguelRodo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Adds a standalone test to cover the validation gap in
src/mermaid/install.shwhere the script ensuresUSERNAMEis formatted correctly (preventing option/command injection).📊 Coverage: The test runs the installation script locally with
USERNAME="-invalid"and asserts that the failure condition is triggered and the correct error message is logged.✨ Result: Enhanced test coverage that catches bugs in user input validation logic before they cause silent or confusing failures during the DevContainer build phase.
PR created automatically by Jules for task 3200687924583980853 started by @MiguelRodo