Skip to content

🧹 [code health improvement] simplify directory traversal checks in renv-cache #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiguelRodo merged 1 commit into from
May 15, 2026
Merged

🧹 [code health improvement] simplify directory traversal checks in renv-cache #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/renv-cache/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ empty_dir() {
fi

# Block path traversal and root-equivalent segments ( . and .. )
if [[ "$directory" == *"/./"* || "$directory" == *"/../"* || "$directory" == "/." || "$directory" == "/.." || "$directory" == */. || "$directory" == */.. ]]; then
if [[ "$directory" =~ (/\.($|/)|/\.\.($|/)) ]]; then
echo "[ERROR] Refusing to empty directory: '$directory' (unsafe segment: . or ..)"
return 1
fi
Expand Down Expand Up @@ -132,7 +132,7 @@ rm_dirs() {
fi

# Block path traversal and root-equivalent segments ( . and .. )
if [[ "$dir" == *"/./"* || "$dir" == *"/../"* || "$dir" == "/." || "$dir" == "/.." || "$dir" == */. || "$dir" == */.. ]]; then
if [[ "$dir" =~ (/\.($|/)|/\.\.($|/)) ]]; then
echo "[ERROR] Refusing to remove directory: '$dir' (unsafe segment: . or ..)"
continue
fi
Expand Down
Loading