🔒 fix: prevent sudo option injection in mmdc script#224
Conversation
Add `--` delimiter to `sudo` execution in `src/mermaid/cmd/mmdc` to prevent option injection vulnerabilities when passing arguments via `$@`. Co-authored-by: MiguelRodo <23501332+MiguelRodo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed a potential option injection vulnerability in
⚠️ Risk: If a user managed to pass options starting with
src/mermaid/cmd/mmdcwhen executingsudo.-to the script, they could potentially inject arguments into thesudocommand itself, potentially leading to unauthorized privilege escalation or unexpected behavior.🛡️ Solution: Added the
--end-of-options delimiter to thesudocall (sudo -u "$USERNAME" -- mmdc ...), forcingsudoto treat all subsequent arguments as the command to execute, neutralizing the option injection vector.PR created automatically by Jules for task 5765281476970171348 started by @MiguelRodo