Skip to content

🔒 fix: prevent sudo option injection in mmdc script#224

Merged
MiguelRodo merged 2 commits into
mainfrom
fix-sudo-option-injection-5765281476970171348
May 18, 2026
Merged

🔒 fix: prevent sudo option injection in mmdc script#224
MiguelRodo merged 2 commits into
mainfrom
fix-sudo-option-injection-5765281476970171348

Conversation

@MiguelRodo
Copy link
Copy Markdown
Owner

🎯 What: Fixed a potential option injection vulnerability in src/mermaid/cmd/mmdc when executing sudo.
⚠️ Risk: If a user managed to pass options starting with - to the script, they could potentially inject arguments into the sudo command itself, potentially leading to unauthorized privilege escalation or unexpected behavior.
🛡️ Solution: Added the -- end-of-options delimiter to the sudo call (sudo -u "$USERNAME" -- mmdc ...), forcing sudo to treat all subsequent arguments as the command to execute, neutralizing the option injection vector.


PR created automatically by Jules for task 5765281476970171348 started by @MiguelRodo

Add `--` delimiter to `sudo` execution in `src/mermaid/cmd/mmdc` to prevent option injection vulnerabilities when passing arguments via `$@`.

Co-authored-by: MiguelRodo <23501332+MiguelRodo@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@MiguelRodo MiguelRodo merged commit ffd4005 into main May 18, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant