Some characters non-printable in 8-bit codepage encoding in mcedit

[CkNoSFeRaTU]

Is there an existing issue for this?

• I have searched the existing issues

Midnight Commander version

GNU Midnight Commander 4.8.33
Built with GLib 2.84.0
Built with S-Lang 2.3.3 with terminfo database
Built with libssh2 1.11.1
With builtin editor and aspell support
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
With ext2fs attributes support
Virtual File Systems:
 cpiofs, tarfs, sfs, extfs, ftpfs, sftpfs, shell
Data types:
 char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64; uintmax_t: 64;

Operating system

Linux nosferatu 6.13.5-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 27 Feb 2025 18:09:44 +0000 x86_64 GNU/Linux

Is this issue reproducible using the latest version of Midnight Commander?

• I confirm the issue is still reproducible with the latest version of Midnight Commander

Current behavior

CP866 encoding in mc v4.8.33 and current master:

Expected behavior

CP866 encoding in mc v4.8.32

Additional context

Reverting commit f4ef5c6 fixes this.

[zyv]

Second commit fixes an issue introduced in 1e0e6b5 .

I did some testing, and oh man, this looks complicated.

Tested with UTF-8, CP866, CP-1251 and KOI8-R files:

• test-rendering-utf8.txt
• test-rendering-cp866.txt
• test-rendering-cp1251.txt
• test-rendering-koi8.txt

	Branch	Charset	Terminal	LC_ALL	Result editor	Result viewer
1	master	Yes	UTF-8	en_GB.UTF-8	Translation is broken	All OK
2	#4668	Yes	UTF-8	en_GB.UTF-8	All OK	All OK
3	#4668	Yes	CP866	ru_RU.CP866	Wrong rendering	Wrong rendering
4	#4668	Yes	CP866	en_GB.UTF-8	Screen corruption	Screen corruption
5	#4668	No	UTF-8	en_GB.UTF-8	Wrong rendering	Wrong rendering
6	#4668	No	CP866	ru_RU.CP866	Wrong rendering	Wrong rendering

/cc @egmontkob @aborodin

Footnotes

1. mc from Homebrew ↩

2. All OK: no screen corruption, translation works correctly ↩

3. LC_ALL=ru_RU.CP866 ~/src/mc/master/build/install/bin/mc, translation works correctly ↩

4. For single-byte files, all OK, for UTF-8 file - screen corruption ↩

5. Expected UTF-8 to be pass-through? Different results for editor and viewer. ↩

6. Same as now on master. ↩

[mc-worker]

Related issues: #3257, #2180.