fix: make capturePane tmux integration test more resilient#508
Merged
Conversation
Add unique session name with nanosecond suffix to avoid collisions when running alongside other tmux-using tests. Add retry logic for tmux new-session (3 attempts with 500ms pause) to handle transient tmux server contention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
TestCapturePane_FullScrollback_ReturnsHistoryBeyondVisibleintegration test was flaky when running in the fullcmd/ctsuite because of tmux session name collisions and transient server contention.Changes:
time.Now().UnixNano()%10000) to avoid collisions with other tmux-using teststmux new-sessionto handle transient tmux server contentionThe test already skips in CI (
os.Getenv("CI") != "") — this makes it more reliable for local development.