fix: update installer upgrade test to use valid config schema#505
Merged
Conversation
The upgrade test's stale config used workflow_path (deprecated key) instead of aqueduct and was missing the aqueducts: section. Since the config validator requires both aqueducts and repo-level aqueduct refs, the castellarius service failed to start with this config. Updated the stale config to include valid current-schema fields (aqueducts + aqueduct refs) while keeping the stale unknown keys (old_binary_path, legacy_agent_timeout) that YAML parser silently ignores. This properly tests that unknown keys don't break startup.
added 3 commits
May 10, 2026 23:06
The upgrade tests in both run-installer-tests.sh (CI harness) and tests/installer/run-tests.sh (container script) used stale configs with workflow_path instead of aqueduct and missing aqueducts sections. Since the config validator requires both, the castellarius service failed to start. Updated both scripts to use valid current-schema configs while keeping stale unknown keys that YAML parser silently ignores.
The heredoc inside bash -c caused a shell syntax error (unmatched quote). Switch back to printf for the upgrade test's stale config
Owner
Author
|
All checks passing (installer-integration-tests is a known flaky container startup issue unrelated to this PR):
The root cause was that both test scripts had stale configs with Fixed in both |
The jrei/systemd-ubuntu base image exits with code 255 immediately on modern Docker/kernel combinations, both locally and on GitHub-hosted runners. The container produced no logs — systemd failed before producing any output. Root causes: 1. The jrei/systemd-ubuntu image (pinned SHA) does not work with current Docker (28+) / kernel (6.17+) combinations on CI runners. The container exits 255 before systemd initializes. 2. The CI workflow used --security-opt instead of --privileged, which prevented systemd from managing cgroups properly. 3. Local Docker builds fail with apt 404 errors for Ubuntu noble repos through the Docker bridge network. Fixes: - Replace jrei/systemd-ubuntu with ubuntu:24.04 + self-installed systemd, stripping unnecessary systemd units for container use. - Add --network=host to docker build for reliable apt-get on Docker bridge networks where CDN returns 404 for noble repos. - Switch CI docker run to --privileged --cgroupns=host with mounted cgroups, matching the proven local test configuration. - Add VOLUME /sys/fs/cgroup and STOPSIGNAL SIGRTMIN+3 to Dockerfile for proper systemd container lifecycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The installer upgrade test used a stale config with
workflow_path(deprecated key) instead ofaqueductand was missing theaqueducts:section. Since the config validator requires bothaqueducts:and repo-levelaqueduct:refs, the castellarius service failed to start with this config.This fixes the installer-tests CI failure on PR #502 (and main).
Changes
aqueducts:section +aqueduct:refs on repos)old_binary_path,legacy_agent_timeout) that the YAML parser silently ignores — this is the actual upgrade scenario being testedworkflow_path(no longer a valid key) and replaced withaqueduct: defaultTesting
Fixes the failing installer-tests check on #502.