Skip to content

Commit 3a1488c

Browse files
author
MichaC
authored
Fixing memory leak when using nameserver discovery and NetworkAddressChanged events (#68)
Removing usage of NetworkChange.NetworkAddressChanged usage to refresh discovered name-servers.
1 parent db2d7cf commit 3a1488c

2 files changed

Lines changed: 1 addition & 20 deletions

File tree

src/DnsClient/DnsClient.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<VersionPrefix>1.3.0</VersionPrefix>
3+
<VersionPrefix>1.3.1</VersionPrefix>
44
<VersionSuffix Condition="'$(VersionSuffix)'!='' AND '$(BuildNumber)' != ''">$(VersionSuffix)-$(BuildNumber)</VersionSuffix>
55

66
<TargetFrameworks>netstandard1.3;netstandard2.0;netstandard2.1;net45;net471</TargetFrameworks>

src/DnsClient/LookupClient.cs

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -377,15 +377,6 @@ internal LookupClient(LookupClientOptions options, DnsMessageHandler udpHandler
377377
{
378378
_resolvedNameServers = NameServer.ResolveNameServers(skipIPv6SiteLocal: true, fallbackToGooglePublicDns: false);
379379
servers = servers.Concat(_resolvedNameServers).ToArray();
380-
381-
try
382-
{
383-
NetworkChange.NetworkAddressChanged += CheckResolvedNameserversCallback;
384-
}
385-
catch
386-
{
387-
// Just in case
388-
}
389380

390381
// This will periodically get triggered on Query calls and
391382
// will perform the same check as on NetworkAddressChanged.
@@ -408,16 +399,6 @@ internal LookupClient(LookupClientOptions options, DnsMessageHandler udpHandler
408399
Cache = new ResponseCache(true, Settings.MinimumCacheTimeout, Settings.MaximumCacheTimeout);
409400
}
410401

411-
private void CheckResolvedNameserversCallback(object sender, EventArgs args)
412-
{
413-
if (_logger.IsEnabled(LogLevel.Information))
414-
{
415-
_logger.LogInformation("Network change detected, trying to resolve name servers...");
416-
}
417-
418-
CheckResolvedNameservers();
419-
}
420-
421402
private void CheckResolvedNameservers()
422403
{
423404
try

0 commit comments

Comments
 (0)