This repository was archived by the owner on May 9, 2018. It is now read-only.
Fix the custom merge sort, which could lead to crash on very simple data#3
Open
ChengCat wants to merge 1 commit into
Open
Fix the custom merge sort, which could lead to crash on very simple data#3ChengCat wants to merge 1 commit into
ChengCat wants to merge 1 commit into
Conversation
It may requires sorting when "InHalf1[-1]->Y == InHalf1[0]->Y".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the library!
I encountered crash when testing it with very simple data. Fortunately, it it not hard to find the bug. In the custom merge sort function, it may requires sorting when
InHalf1[-1]->Y == InHalf1[0]->Y.Also note that, the way epsilon is used in the sorting section is incorrect. For the following points, both
MPE_POLY_COMPARE(A, B)andMPE_POLY_COMPARE(B, A)aretrue.I can make another pull request for this.