Skip to content

Commit e9c1916

Browse files
committed
feat(INFRA-2772): fixed quoting
1 parent 190645b commit e9c1916

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

.github/workflows/create-release-pr.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -168,11 +168,11 @@ jobs:
168168
CURRENT_VERSION="${{ inputs.semver-version }}"
169169
NEXT_VERSION=$(node -e "
170170
const semver = require('semver');
171-
const current = '$CURRENT_VERSION';
171+
const current = \"$CURRENT_VERSION\";
172172
const next = semver.inc(current, 'minor');
173173
console.log(next);
174174
")
175-
echo "next-version=$NEXT_VERSION" >> $GITHUB_OUTPUT
175+
echo "next-version=$NEXT_VERSION" >> "$GITHUB_OUTPUT"
176176
echo "Next version will be: $NEXT_VERSION"
177177
178178
# Step 5: Create version bump branch
@@ -181,7 +181,7 @@ jobs:
181181
BRANCH_NAME="bump-main-version-${{ steps.calc-version.outputs.next-version }}"
182182
183183
# Check if branch already exists locally or remotely
184-
if git show-ref --verify --quiet refs/heads/"$BRANCH_NAME" || git ls-remote --heads origin "$BRANCH_NAME" | grep -q "$BRANCH_NAME"; then
184+
if git show-ref --verify --quiet "refs/heads/$BRANCH_NAME" || git ls-remote --heads origin "$BRANCH_NAME" | grep -q "$BRANCH_NAME"; then
185185
echo "Branch $BRANCH_NAME already exists, checking it out"
186186
if git ls-remote --heads origin "$BRANCH_NAME" | grep -q "$BRANCH_NAME"; then
187187
git fetch origin "$BRANCH_NAME"
@@ -194,7 +194,7 @@ jobs:
194194
git checkout -b "$BRANCH_NAME"
195195
fi
196196
197-
echo "branch-name=$BRANCH_NAME" >> $GITHUB_OUTPUT
197+
echo "branch-name=$BRANCH_NAME" >> "$GITHUB_OUTPUT"
198198
id: create-branch
199199

200200
# Step 6: Update version using set-semvar-version.sh
@@ -227,10 +227,10 @@ jobs:
227227
# Step 8: Push branch
228228
- name: Push version bump branch
229229
run: |
230-
if ! git push --set-upstream origin ${{ steps.create-branch.outputs.branch-name }}; then
230+
if ! git push --set-upstream origin "${{ steps.create-branch.outputs.branch-name }}"; then
231231
echo "No changes to push to ${{ steps.create-branch.outputs.branch-name }}"
232232
# Check if branch exists remotely
233-
if git ls-remote --heads origin ${{ steps.create-branch.outputs.branch-name }} | grep -q ${{ steps.create-branch.outputs.branch-name }}; then
233+
if git ls-remote --heads origin "${{ steps.create-branch.outputs.branch-name }}" | grep -q "${{ steps.create-branch.outputs.branch-name }}"; then
234234
echo "Branch ${{ steps.create-branch.outputs.branch-name }} already exists remotely"
235235
else
236236
echo "Error: Failed to push and branch doesn't exist remotely"
@@ -244,7 +244,7 @@ jobs:
244244
GH_TOKEN: ${{ secrets.github-token }}
245245
run: |
246246
# Check if PR already exists
247-
if gh pr list --head ${{ steps.create-branch.outputs.branch-name }} --json number --jq 'length' | grep -q "1"; then
247+
if gh pr list --head "${{ steps.create-branch.outputs.branch-name }}" --json number --jq 'length' | grep -q "1"; then
248248
echo "PR for branch ${{ steps.create-branch.outputs.branch-name }} already exists"
249249
else
250250
gh pr create \
@@ -275,7 +275,7 @@ jobs:
275275
---
276276
*This PR was automatically created by the \`create-release-pr\` workflow.*" \
277277
--base main \
278-
--head ${{ steps.create-branch.outputs.branch-name }} \
278+
--head "${{ steps.create-branch.outputs.branch-name }}" \
279279
--label "release-management" \
280280
--label "version-bump" \
281281
--assignee @me

0 commit comments

Comments
 (0)