Skip to content

Commit 092bb61

Browse files
committed
chore: test passing branch name as argument
1 parent f80f44e commit 092bb61

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

.github/scripts/create-platform-release-pr.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ if [[ -z $NEW_VERSION_NUMBER && $PLATFORM == "mobile" ]]; then
3232
exit 1
3333
fi
3434

35-
35+
if [[ -z $RELEASE_BRANCH_NAMING ]]; then
36+
echo "Error: No release branch naming specified."
37+
exit 1
38+
fi
3639

3740

3841
# Helper Functions
@@ -72,10 +75,11 @@ get_release_branch_name() {
7275
if [ "$TEST_ONLY" == "true" ]; then
7376
echo "release-testing/${new_version}"
7477
return 0
75-
else
76-
echo "${new_version}"
7778
fi
7879

80+
# Use consistent release branch naming for all platforms
81+
echo "$RELEASE_BRANCH_NAMING${new_version}"
82+
7983
# Different release branch naming for different platforms
8084
# if [[ "$platform" == "mobile" ]]; then
8185
# echo "release/${new_version}"

.github/workflows/create-release-pr.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ on:
4949
type: string
5050
description: 'The version of github-tools to use. Defaults to main.'
5151
default: 'main'
52+
release-branch-naming:
53+
required: false
54+
type: string
55+
description: 'The naming convention for the release branch.'
56+
default: 'release/'
5257
secrets:
5358
github-token:
5459
required: true
@@ -98,6 +103,7 @@ jobs:
98103
echo "Semver Version: ${{ inputs.semver-version }}"
99104
echo "Previous Version Tag: ${{ inputs.previous-version-tag }}"
100105
echo "Test Only Mode: ${{ inputs.test-only }}"
106+
echo "Release Branch Naming: ${{ inputs.release-branch-naming }}"
101107
if [[ "${{ inputs.platform }}" == "mobile" ]]; then
102108
echo "Mobile Build Version: ${{ inputs.mobile-build-version }}"
103109
fi
@@ -119,6 +125,7 @@ jobs:
119125
BASE_BRANCH: ${{ inputs.base-branch }}
120126
GITHUB_REPOSITORY_URL: '${{ github.server_url }}/${{ github.repository }}'
121127
TEST_ONLY: ${{ inputs.test-only }}
128+
RELEASE_BRANCH_NAMING: ${{ inputs.release-branch-naming }}
122129
GOOGLE_DOCUMENT_ID: ${{ inputs.release-sheet-google-document-id }}
123130
GOOGLE_APPLICATION_CREDENTIALS_BASE64: ${{ secrets.google-application-creds-base64 }}
124131
NEW_VERSION: ${{ inputs.semver-version }}

0 commit comments

Comments
 (0)