Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Add Ledger hd paths support on Trezor device #142

@Lafudoci

Description

@Lafudoci

Hi, I have made my Trezor with migrated Ledger seed worked on Metamask. But I am amateur at this so I'd like to open an issue for discussion before opening a PR.

The reason to do this is because when I imported my broken Ledger seed to the new Trezor, the metamask could not find the correct address, they are using different path. But this totally don't make sense to me, seeds should be interoperability.

So I made these changes to make it work. Tested on my Trezor device.

First, for eth-trezor-keyring, allow Ledger paths:
Lafudoci@ca525ac

Second, add Ledger path options to metamask trezor connection script:
Lafudoci/metamask-extension@49d433e#diff-0a2a225e26cc8840b2d6e5b4acf30923de787fbcf19efb5766f04ba8bd8e433f

Besides, change safety checks setting from strict to prompt in the Trezor suite is also needed.

How do you think? Are these changes good to put into public release? I'll need to open 2 PR for eth-trezor-keyring and metamask.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions