Fix lint issues and prune stale ESLint suppressions

Author: pedronfigueiredo

eslint-suppressions.json

@@ -1419,9 +1419,6 @@
     "@typescript-eslint/explicit-function-return-type": {
       "count": 4
     },
-    "@typescript-eslint/prefer-nullish-coalescing": {
-      "count": 4
-    },
     "id-length": {
       "count": 2
     },

packages/multichain-account-service/src/providers/BaseBip44AccountProvider.ts

@@ -130,8 +130,7 @@ export abstract class BaseBip44AccountProvider<
       'AccountsController:getAccounts',
       accountsIds,
     );
-    // we cast here because we know that the accounts are BIP-44 compatible
-    return internalAccounts as unknown as Account[];
+    return internalAccounts;
   }
 
   /**
@@ -148,12 +147,7 @@ export abstract class BaseBip44AccountProvider<
       throw new Error(`Unable to find account: ${id}`);
     }
 
-    // We need to upcast here since InternalAccounts are not always BIP-44 compatible
-    // but we know that the account is BIP-44 compatible here so it is safe to do so
-    return this.messenger.call(
-      'AccountsController:getAccount',
-      id,
-    ) as unknown as Account;
+    return this.messenger.call('AccountsController:getAccount', id);
   }
 
   protected async withKeyring<SelectedKeyring, CallbackResult = void>(

packages/profile-sync-controller/src/controllers/user-storage/contact-syncing/controller-integration.ts

@@ -81,7 +81,7 @@ export async function syncContactsWithUserStorage(
       .filter((contact) => !isContactBridgedFromAccounts(contact))
       .filter(
         (contact) => contact.address && contact.chainId && contact.name?.trim(),
-      ) || [];
+      ) ?? [];
 
   // Get remote contacts from user storage API
   const remoteContacts = await getRemoteContacts(options);
@@ -90,7 +90,7 @@ export async function syncContactsWithUserStorage(
   const validRemoteContacts =
     remoteContacts?.filter(
       (contact) => contact.address && contact.chainId && contact.name?.trim(),
-    ) || [];
+    ) ?? [];
 
   const performSync = async () => {
     try {
@@ -140,8 +140,8 @@ export async function syncContactsWithUserStorage(
 
           if (hasContentDifference) {
             // Check timestamps to determine which version to keep
-            const localTimestamp = localContact.lastUpdatedAt || 0;
-            const remoteTimestamp = remoteContact.lastUpdatedAt || 0;
+            const localTimestamp = localContact.lastUpdatedAt ?? 0;
+            const remoteTimestamp = remoteContact.lastUpdatedAt ?? 0;
 
             if (localTimestamp >= remoteTimestamp) {
               // Local is newer (or same age) - use local version
@@ -383,7 +383,7 @@ export async function updateContactInRemoteStorage(
     // Create an updated entry with timestamp
     const updatedEntry = {
       ...contact,
-      lastUpdatedAt: contact.lastUpdatedAt || Date.now(),
+      lastUpdatedAt: contact.lastUpdatedAt ?? Date.now(),
     } as SyncAddressBookEntry;
 
     const key = createContactKey(contact);

packages/react-data-query/src/createUIQueryClient.test.ts

@@ -336,7 +336,7 @@ describe('createUIQueryClient', () => {
     const promise = new Promise<Error>((_resolve, reject) => {
       observer.subscribe((event) => {
         if (event.status === 'error') {
-          reject(event.error as Error);
+          reject(event.error);
         }
       });
     });