Skip to content

Commit 0d3c01d

Browse files
Move UI-specific code to react-data-query
1 parent 3adfec4 commit 0d3c01d

13 files changed

Lines changed: 46 additions & 30 deletions

File tree

packages/base-data-service/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
"@metamask/messenger": "^0.3.0",
5353
"@metamask/utils": "^11.9.0",
5454
"@tanstack/query-core": "^4.43.0",
55-
"@tanstack/react-query": "^4.43.0",
5655
"fast-deep-equal": "^3.1.3"
5756
},
5857
"devDependencies": {

packages/base-data-service/src/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,3 @@ export type {
99
QueryKey,
1010
} from './BaseDataService';
1111
export { BaseDataService } from './BaseDataService';
12-
export { createUIQueryClient } from './createUIQueryClient';
13-
export { useQuery, useInfiniteQuery } from './hooks';

packages/base-data-service/tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"baseUrl": "./"
55
},
66
"references": [
7-
{ "path": "../messenger/tsconfig.build.json" },
8-
{ "path": "../controller-utils/tsconfig.build.json" }
7+
{ "path": "../messenger" },
8+
{ "path": "../controller-utils" }
99
],
1010
"include": ["../../types", "./src", "./tests"]
1111
}

packages/react-data-query/package.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,11 @@
4646
"test:verbose": "NODE_OPTIONS=--experimental-vm-modules jest --verbose",
4747
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
4848
},
49+
"dependencies": {
50+
"@metamask/utils": "^11.10.0",
51+
"@tanstack/query-core": "^4.43.0",
52+
"@tanstack/react-query": "^4.43.0"
53+
},
4954
"devDependencies": {
5055
"@metamask/auto-changelog": "^3.4.4",
5156
"@ts-bridge/cli": "^0.6.4",
@@ -57,6 +62,11 @@
5762
"typedoc-plugin-missing-exports": "^2.0.0",
5863
"typescript": "~5.3.3"
5964
},
65+
"peerDependencies": {
66+
"react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0",
67+
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0",
68+
"react-native": "*"
69+
},
6070
"engines": {
6171
"node": "^18.18 || >=20"
6272
},

packages/base-data-service/src/createUIQueryClient.test.ts renamed to packages/react-data-query/src/createUIQueryClient.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ import {
1414
ExampleDataServiceEvents,
1515
GetActivityResponse,
1616
PageParam,
17-
} from '../tests/ExampleDataService';
17+
} from '../../base-data-service/tests/ExampleDataService';
1818
import {
1919
mockAssets,
2020
mockTransactionsPage1,
2121
mockTransactionsPage2,
22-
} from '../tests/mocks';
22+
} from '../../base-data-service/tests/mocks';
2323

2424
const DATA_SERVICES = ['ExampleDataService'];
2525

packages/base-data-service/src/createUIQueryClient.ts renamed to packages/react-data-query/src/createUIQueryClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
QueryKey,
1010
} from '@tanstack/query-core';
1111

12-
import { GranularCacheUpdatedPayload } from './BaseDataService';
12+
import { GranularCacheUpdatedPayload } from '@metamask/base-data-service';
1313

1414
type SubscriptionCallback = (payload: GranularCacheUpdatedPayload) => void;
1515
type JsonSubscriptionCallback = (data: Json) => void;
File renamed without changes.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
UseInfiniteQueryResult,
1111
} from '@tanstack/react-query';
1212

13-
import { QueryKey } from './BaseDataService';
13+
import { QueryKey } from '@metamask/base-data-service';
1414

1515
// We provide re-exports of the underlying TanStack Query hooks with narrower types,
1616
// removing `staleTime` and `queryFn` which aren't useful when using data services.

packages/react-data-query/src/index.test.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.
Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,2 @@
1-
/**
2-
* Example function that returns a greeting for the given name.
3-
*
4-
* @param name - The name to greet.
5-
* @returns The greeting.
6-
*/
7-
export default function greeter(name: string): string {
8-
return `Hello, ${name}!`;
9-
}
1+
export { createUIQueryClient } from './createUIQueryClient';
2+
export { useQuery, useInfiniteQuery } from './hooks';

0 commit comments

Comments
 (0)