fix inline config

Author: Mavrin

package.json

@@ -2,7 +2,7 @@
   "name": "gitbook-plugin-jsfiddle",
   "description": "JSFiddle Integration into GitBook",
   "main": "index.js",
-  "version": "1.0.0-alpha.5",
+  "version": "1.0.0-alpha.6",
   "author": {
     "name": "Konstantin Krivlenia"
   },

src/replace.js

@@ -29,7 +29,7 @@ var htmlToDom = function (html) {
 var extractConfigFromURL = function (href) {
     var match = /(#)(.+)$/ig.exec(href);
     if (match && match[2]) {
-        return match[2].split('&').reduce(function (params, param) {
+        return match[2].split('&').reduce(function (params, param) {
             var splitParam = param.split('=');
             if (splitParam[0] === 'tabs') {
                 splitParam[1] = splitParam[1].split(',');
@@ -50,7 +50,10 @@ var generateAdditionalParams = function (config) {
         return colors;
     }, '');
     colors = colors.replace(/&$/, '');
-    return params + '?' + colors;
+    if (colors) {
+        return params + '?' + colors;
+    }
+    return params;
 };
 
 var generateUrl = function (config) {
@@ -69,7 +72,7 @@ var creator = {
             ' width=',
             '"' + (config.width ? config.width : '100%') + '"',
             ' height=',
-            '"' + (config.height ? config.height : '300px') + '"',
+            '"' + (config.height ? config.height : '300') + '"',
             ' src="' + generateUrl(config) + '"',
             ' allowfullscreen="allowfullscreen" frameborder="0"',
             '>',

tests/replace.js

@@ -36,17 +36,17 @@ test('replacer', function (assert) {
             tabs: ['js', 'result']
         }),
         `<div>
-          <iframe width="100%" height="300px" src="//jsfiddle.net/zalun/NmudS/embedded/js,result/dark/?bodyColor=red&accentColor=red" allowfullscreen="allowfullscreen" frameborder="0"></iframe>
+          <iframe width="100%" height="300" src="//jsfiddle.net/zalun/NmudS/embedded/js,result/dark/?bodyColor=red&accentColor=red" allowfullscreen="allowfullscreen" frameborder="0"></iframe>
         </div>`.replace(/\s+/g, ' ')
         , 'replace on frame with params and dark theme');
     assert.equal(
         replace(
-            '<div><a href="https://jsfiddle.net/09bv780j/#tabs=result,css&width=500px&type=script&theme=dark&bodyColor=blue"></a></div>',
+            '<div><a href="https://jsfiddle.net/09bv780j/#tabs=result,css&amp;width=500px&amp;type=script&amp;theme=dark&amp;bodyColor=blue"></a></div>',
             {
-                bodyColor:'red',
-                type:'frame',
+                bodyColor: 'red',
+                type: 'frame',
                 accentColor: 'red',
-                tabs:['js']
+                tabs: ['js']
             }
         ),
         '<div><script async src="https://jsfiddle.net/09bv780j/embed/result,css/dark/?bodyColor=blue&accentColor=red"></script></div>',