Add nullalbe exchange on company search search (#35)

* Add nullalbe exchange on company search search

* fixed unit test

Co-authored-by: Walter Franssen <walter.franssen@centric.eu>

Author: walterfranssen

FinancialModelingPrepApi/Abstractions/CompanyValuation/ICompanyValuationProvider.cs

@@ -11,8 +11,8 @@ public interface ICompanyValuationProvider
         public Task<ApiResponse<List<QuoteResponse>>> GetQuotesAsync(IEnumerable<string> symbols);
         public Task<ApiResponse<List<QuoteResponse>>> GetQuotesAsync(Exchange exchange);
 
-        public Task<ApiResponse<List<TickerSearchResponse>>> SearchAsync(string query, Exchange exchange, int? limit = null);
-        public Task<ApiResponse<List<TickerSearchResponse>>> SearchByTickerAsync(string query, Exchange exchange, int? limit = null);
+        public Task<ApiResponse<List<TickerSearchResponse>>> SearchAsync(string query, Exchange? exchange, int? limit = null);
+        public Task<ApiResponse<List<TickerSearchResponse>>> SearchByTickerAsync(string query, Exchange? exchange, int? limit = null);
 
         public Task<ApiResponse<CompanyProfileResponse>> GetCompanyProfileAsync(string symbol);
         public Task<ApiResponse<RatiosTTMResponse>> GetRatiosTTMAsync(string symbol);

FinancialModelingPrepApi/Core/CompanyValuation/CompanyValuationProvider.cs

@@ -504,13 +504,13 @@ public Task<ApiResponse<List<MarketCapResponse>>> GetHistoricalMarketCapitalizat
             return client.GetJsonAsync<List<MarketCapResponse>>(url, pathParams, queryString);
         }
 
-        public Task<ApiResponse<List<TickerSearchResponse>>> SearchAsync(string query, Exchange exchange, int? limit = null)
+        public Task<ApiResponse<List<TickerSearchResponse>>> SearchAsync(string query, Exchange? exchange, int? limit = null)
             => SearchInternalAsync(query, exchange, false, limit);
 
-        public Task<ApiResponse<List<TickerSearchResponse>>> SearchByTickerAsync(string query, Exchange exchange, int? limit = null)
+        public Task<ApiResponse<List<TickerSearchResponse>>> SearchByTickerAsync(string query, Exchange? exchange, int? limit = null)
             => SearchInternalAsync(query, exchange, true, limit);
 
-        private Task<ApiResponse<List<TickerSearchResponse>>> SearchInternalAsync(string query, Exchange exchange, bool byTicker, int? limit)
+        private Task<ApiResponse<List<TickerSearchResponse>>> SearchInternalAsync(string query, Exchange? exchange, bool byTicker, int? limit)
         {
             const string url = "[version]/search";
             const string urlByTicker = "[version]/search-ticker";
@@ -523,7 +523,7 @@ private Task<ApiResponse<List<TickerSearchResponse>>> SearchInternalAsync(string
             var queryString = new QueryStringBuilder();
 
             queryString.Add("query", query);
-            queryString.Add("exchange", exchange.ToString());
+            if (exchange.HasValue) queryString.Add("exchange", exchange.Value.ToString());
 
             if (limit != null)
             {

Tests/CompanyValuation/CompanyValuationTests.cs

@@ -363,6 +363,19 @@ public async Task SearchByTickerAsync()
             Assert.Equal("AGS.BR", firstResult.Symbol);
         }
 
+        [Fact]
+        public async Task SearchByTickerWithoutExchangeAsync()
+        {
+            var result = await api.SearchByTickerAsync("AAPL", null, 5);
+
+            result.AssertNoErrors();
+            Assert.NotEmpty(result.Data);
+            Assert.True(result.Data.Count >= 1);
+
+            var firstResult = result.Data.First(_ => _.Symbol == "AAPL");
+            Assert.Equal("AAPL", firstResult.Symbol);
+        }
+
         [Fact]
         public async Task GetHistoricalMarketCapAsync()
         {