Commands that throw exception cause parsing to fail (#28)

* Update C# Version and nuspec

* Create default parser and constructor for CommandLineParserOptions

* Add test for multiple non required commands with required options

* Fix #25 non required commands will no longer trigger an error result.

* Fix #24

* Add ctor tests

* Fixes #27

Author: Matthiee

CommandLineParser.Tests/CommandLineParserTests.cs

@@ -1,4 +1,6 @@
-using System.Threading;
+using System;
+using System.Linq;
+using System.Threading;
 
 using MatthiWare.CommandLine;
 using MatthiWare.CommandLine.Abstractions;
@@ -109,6 +111,26 @@ public void CommandLinerParserPassesResolverAndContainerCorreclty()
             Assert.Equal(options, parser.ParserOptions);
         }
 
+        [Fact]
+        public void AutoExecuteCommandsWithExceptionDoesntCrashTheParser()
+        {
+            var parser = new CommandLineParser();
+
+            var ex = new Exception("uh-oh");
+
+            parser.AddCommand()
+                .Name("test")
+                .InvokeCommand(true)
+                .Required(true)
+                .OnExecuting(_ => throw ex);
+
+            var result = parser.Parse(new[] { "test" });
+
+            Assert.True(result.HasErrors);
+
+            Assert.Equal(ex, result.Errors.First());
+        }
+
         [Fact]
         public void CommandLineParserUsesArgumentFactoryCorrectly()
         {

CommandLineParser/CommandLineParser`TOption.cs

@@ -268,11 +268,11 @@ private void PrintErrors(IReadOnlyCollection<Exception> errors)
 
         private void PrintHelp() => Printer.PrintUsage();
 
-        private void AutoExecuteCommands(IParserResult<TOption> result)
+        private void AutoExecuteCommands(ParseResult<TOption> result)
         {
             if (result.HasErrors) return;
 
-            ExecuteCommandParserResults(result.CommandResults.Where(r => r.Command.AutoExecute));
+            ExecuteCommandParserResults(result, result.CommandResults.Where(sub => sub.Command.AutoExecute));
         }
 
         private bool HelpRequested(ParseResult<TOption> result, CommandLineOptionBase option, ArgumentModel model)
@@ -291,13 +291,27 @@ private bool HelpRequested(ParseResult<TOption> result, CommandLineOptionBase op
             return false;
         }
 
-        private void ExecuteCommandParserResults(IEnumerable<ICommandParserResult> results)
+        private void ExecuteCommandParserResults(ParseResult<TOption> results, IEnumerable<ICommandParserResult> cmds)
         {
-            foreach (var cmd in results)
-                cmd.ExecuteCommand();
+            var errors = new List<Exception>();
+
+            foreach (var cmd in cmds)
+            {
+                try
+                {
+                    cmd.ExecuteCommand();
+                }
+                catch (Exception ex)
+                {
+                    errors.Add(ex);
+                }
+            }
+
+            if (errors.Any())
+                results.MergeResult(errors);
 
-            foreach (var cmd in results)
-                ExecuteCommandParserResults(cmd.SubCommands.Where(sub => sub.Command.AutoExecute));
+            foreach (var cmd in cmds)
+                ExecuteCommandParserResults(results, cmd.SubCommands.Where(sub => sub.Command.AutoExecute));
         }
 
         private void ParseCommands(IList<Exception> errors, ParseResult<TOption> result, IArgumentManager argumentManager)