fix: async bug with composing connections

the composed flag was set at the beginning of the compose function causing another function to throw an error due to an undefined property if it was called at the same time.

Author: tegefaulkes

src/network/ConnectionReverse.ts

@@ -217,7 +217,6 @@ class ConnectionReverse extends Connection {
       if (this._composed) {
         throw new networkErrors.ErrorConnectionComposed();
       }
-      this._composed = true;
       this.logger.info('Composing Connection Reverse');
       // Promise for secure establishment
       const { p: secureP, resolveP: resolveSecureP } = promise<void>();
@@ -306,6 +305,7 @@ class ConnectionReverse extends Connection {
       });
       this.clientCertChain = clientCertChain;
       this.logger.info('Composed Connection Reverse');
+      this._composed = true;
     } catch (e) {
       this._composed = false;
       throw e;

src/nodes/NodeConnection.ts

@@ -128,7 +128,7 @@ class NodeConnection<T extends GRPCClient> {
           },
           timer: timer,
         }),
-        holePunchPromises,
+        ...holePunchPromises,
       ]);
       // 5. When finished, you have a connection to other node
       // The GRPCClient is ready to be used for requests

src/nodes/NodeConnectionManager.ts

@@ -756,6 +756,7 @@ class NodeConnectionManager {
     const signature = await this.keyManager.signWithRootKeyPair(
       Buffer.from(proxyAddress),
     );
+    // FIXME: this needs to handle aborting
     const holePunchPromises = Array.from(this.getSeedNodes(), (seedNodeId) => {
       return this.sendHolePunchMessage(
         seedNodeId,