Add broad Elixir ecosystem support#199
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
c8e056e to
691cd9c
Compare
691cd9c to
b6babb6
Compare
b6babb6 to
5b841b6
Compare
5b841b6 to
2fca48c
Compare
2fca48c to
36ebded
Compare
💡 Codex ReviewThis template always wires deep-linking into navigation ( Better-Fullstack/apps/cli/src/mcp.ts Line 403 in 2fca48c The MCP project-config builder now defaults ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the Codex review findings in 3b1a753: React Navigation now honors |
|
Follow-up after the Playwright failure: f347c9c fixes the shared command default detector so TypeScript builder changes like |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47af19477d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| config.ecosystem === "react-native" && | ||
| frontend.some((item) => !item.startsWith("native-") && item !== "none") | ||
| ) { |
There was a problem hiding this comment.
Skip React Native frontend check for implicit defaults
This new validation rejects react-native whenever frontend contains a non-native value, but in --yes mode the config is first seeded from TypeScript defaults (tanstack-router) before ecosystem-specific prompting happens, so --yes --ecosystem react-native now fails even though the user did not provide --frontend. The check should only apply when frontend was explicitly provided (or after React Native defaults are normalized), otherwise default React Native scaffolding is blocked.
Useful? React with 👍 / 👎.
11d2803 to
54fc6f6
Compare
54fc6f6 to
aac801b
Compare
|
Closing this duplicate PR so the Elixir ecosystem work is consolidated in #200. |
Summary
Validation
Notes
The branch also contains the prior React Native ecosystem work that this PR was originally opened for; this push adds the Elixir ecosystem work on top.