removing most of stdout communication

Author: MarkoVcode

benchmesh-serial-service/src/benchmesh_service/api.py

@@ -5,6 +5,7 @@
 import asyncio
 import subprocess
 import hashlib
+import logging
 from pathlib import Path
 from contextlib import asynccontextmanager
 from typing import Any, Dict, List
@@ -21,6 +22,8 @@
 import serial.tools.list_ports
 from .transport import discover_usbtmc_devices
 
+logger = logging.getLogger(__name__)
+
 API_PORT = int(os.getenv('API_PORT', '57666'))
 UI_DEV_PORT = int(os.getenv('UI_PORT', '52893'))
 
@@ -474,7 +477,7 @@ def list_serial_ports(exclude: str = ""):
                             continue
             except Exception as e:
                 # Non-fatal - just log and continue with what we have
-                print(f"Warning: Failed to scan /dev for symlinks: {e}")
+                logger.warning(f"Failed to scan /dev for symlinks: {e}")
 
         # Sort by device name for consistent ordering
         result.sort(key=lambda p: p["device"])

benchmesh-serial-service/src/benchmesh_service/device.py

@@ -1,3 +1,8 @@
+import logging
+
+logger = logging.getLogger(__name__)
+
+
 class Device:
     def __init__(self, id, name, port, baud, driver):
         self.id = id
@@ -11,23 +16,23 @@ def connect(self):
         """Establish a serial connection using the specified driver."""
         try:
             self.connection = self.driver.connect(self.port, self.baud)
-            print(f"{self.name} connected on {self.port}")
+            logger.info(f"{self.name} connected on {self.port}")
         except Exception as e:
-            print(f"Failed to connect to {self.name}: {e}")
+            logger.error(f"Failed to connect to {self.name}: {e}")
 
     def send_command(self, command):
         """Send a command to the device."""
         if self.connection:
             self.connection.write(command)
         else:
-            print(f"{self.name} is not connected.")
+            logger.warning(f"{self.name} is not connected.")
 
     def receive_response(self):
         """Receive a response from the device."""
         if self.connection:
             return self.connection.read()
         else:
-            print(f"{self.name} is not connected.")
+            logger.warning(f"{self.name} is not connected.")
             return None
 
     def check_status(self):
@@ -40,4 +45,4 @@ def close(self):
         """Close the connection to the device."""
         if self.connection:
             self.connection.close()
-            print(f"{self.name} connection closed.")
+            logger.info(f"{self.name} connection closed.")

benchmesh-serial-service/src/benchmesh_service/main.py

@@ -8,10 +8,10 @@ def main():
     parser = argparse.ArgumentParser()
     parser.add_argument("--config", "-c", default="config.yaml", help="Path to config YAML")
     args = parser.parse_args()
-    print("Using config file:", args.config)
     logger = setup_logger()
+    logger.info(f"Using config file: {args.config}")
     config = load_config(args.config)
-    print("Loaded config:", config)
+    logger.info(f"Loaded config: {config}")
     serial_manager = SerialManager(config['devices'])
     serial_manager.start()
 

benchmesh-serial-service/src/benchmesh_service/serial_manager.py

@@ -52,8 +52,8 @@ def _load_manifest(driver_key: str) -> Dict:
 
 class SerialManager:
     def __init__(self, config_source: Any, *, resolver: ManifestResolver | None = None, driver_factory: DriverFactory | None = None, clock: Clock | None = None, metrics: MetricsRecorder | None = None, policy: ReconnectPolicy | None = None):
-        print("Initializing SerialManager with config:", config_source)
         self.logger = setup_logger()
+        self.logger.info(f"Initializing SerialManager with config: {config_source}")
         self.devices: List[Dict] = self._load_devices(config_source)
         self.keep_running = True
         self.dev_locks: Dict[str, threading.RLock] = {d.get('id'): threading.RLock() for d in self.devices if d.get('id')}
@@ -126,7 +126,7 @@ def _load_devices(self, source: Any) -> List[Dict]:
             return []
 
     def establish_connections(self):
-        print("Establishing connections to devices...")
+        self.logger.info("Establishing connections to devices...")
         for device in self.devices:
             dev_id = device.get('id')
             if not dev_id: