fix(electron): address PR review — remove generated files, clean up AI copyright, improve CI docs

- Do not commit generated files (Browser/generated/, Browser/wrapper/*.js,
  Browser/wrapper/static/selector-finder.js are all gitignored and regenerated
  by 'invoke build' / the protobuf task).  Squashes the four noisy artifact
  commits (add, fix-import, remove, restore) out of the history.
- Remove the wait_until parameter from New Electron Application (and the
  corresponding test case) — Playwright's electron.launch() does not expose
  a waitUntil option; the keyword now blocks on firstWindow() only.
- Mark the launchElectron / closeElectron / openElectronDevTools functions in
  playwright-state.ts with SPDX snippet tags to clarify they were developed
  with AI assistance and are not under the Robot Framework Foundation copyright.
- Expand node/electron-test-app/README.md with a step-by-step CI setup section
  covering the Xvfb requirement on headless Linux agents and the fact that the
  Electron binary is always downloaded fresh (never committed).

Author: claude

Browser/keywords/electron.py

@@ -11,11 +11,6 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-#
-# NOTE: This file was written with AI assistance (Claude by Anthropic) under
-# the supervision of the contributor. The contributor is the copyright holder
-# for this file; the Robot Framework Foundation copyright above does not extend
-# to AI-generated code.
 
 import json
 from copy import copy
@@ -35,7 +30,6 @@
     keyword,
     logger,
 )
-from ..utils.data_types import PageLoadStates
 
 
 class Electron(LibraryComponent):
@@ -48,7 +42,6 @@ def new_electron_application(
         args: list[str] | None = None,
         env: dict[str, str] | None = None,
         timeout: timedelta = timedelta(seconds=30),
-        wait_until: PageLoadStates = PageLoadStates.domcontentloaded,
         *,
         acceptDownloads: bool = True,
         bypassCSP: bool = False,
@@ -98,7 +91,6 @@ def new_electron_application(
         | ``args``              | Additional command-line arguments forwarded to the Electron process. Use this to pass the entry-point script when running the bare Electron binary, e.g. ``[node/my-app/main.js]``. |
         | ``env``               | Environment variables for the launched process. Merged on top of the current process environment so ``PATH`` and other system variables are still inherited. |
         | ``timeout``           | Maximum time to wait for the first window to appear. Defaults to ``30 seconds``. Pass ``0`` to disable. |
-        | ``wait_until``        | Page-load state to wait for before returning. One of ``load``, ``domcontentloaded`` (default), or ``networkidle``. |
         | ``acceptDownloads``   | Whether to automatically download all attachments. Defaults to ``True``. |
         | ``bypassCSP``         | Toggles bypassing page's Content-Security-Policy. Defaults to ``False``. |
         | ``colorScheme``       | Emulates ``prefers-color-scheme`` media feature: ``dark``, ``light``, ``no-preference``, or ``null`` to disable emulation. |
@@ -201,11 +193,6 @@ def new_electron_application(
             )
             logger.info(response.log)
 
-            load_resp = stub.WaitForPageLoadState(
-                Request().PageLoadState(state=wait_until.name, timeout=timeout_ms)
-            )
-            logger.info(load_resp.log)
-
             video_path = None
             if recordVideo is not None:
                 try:

atest/test/01_Browser_Management/electron.robot

@@ -169,16 +169,6 @@ New Electron Application With Explicit Timeout
     ...    timeout=30 seconds
     Get Title    ==    Browser Library Electron Test App
 
-New Electron Application With Wait Until Load
-    [Documentation]    wait_until=load waits for the load event before
-    ...                returning control to the test.
-    [Teardown]    Close Electron Application
-    @{args}=    Create List    ${ELECTRON_APP_MAIN}
-    New Electron Application
-    ...    executable_path=${ELECTRON_BIN}
-    ...    args=@{args}
-    ...    wait_until=load
-    Get Title    ==    Browser Library Electron Test App
 
 Close Electron Application Removes Active Browser
     [Documentation]    After Close Electron Application there is no active

node/electron-test-app/README.md

@@ -34,23 +34,50 @@ npm start
 
 ## CI integration
 
-The repository `tasks.py` exposes an `electron_test_app` task that runs
-`npm install` in this directory.  The CI workflow calls this task before
-executing the acceptance tests.
+The acceptance tests (``atest/test/01_Browser_Management/electron.robot``) run
+**without skipping** on all platforms in CI. The suite setup runs `npm install`
+inside this directory automatically, so the Electron binary is downloaded fresh
+on each CI run — no pre-built binaries are committed to the repository.
 
-The acceptance tests (``atest/test/01_Browser_Management/electron.robot``) read
-the Electron binary path and the main-process entry-point path from Robot
-Framework variables that are automatically resolved relative to the repository
-root, so no environment variables need to be set on CI.
+### Step-by-step CI setup (Linux)
+
+Electron always opens a native GUI window. On headless Linux agents you must
+provide a virtual display **before** starting the test run:
+
+```bash
+# 1. Install Xvfb (once, during environment setup)
+sudo apt-get install -y xvfb
+
+# 2. Start a virtual display
+Xvfb :99 -screen 0 1280x720x24 &
+export DISPLAY=:99
+
+# 3. Run the project build (compiles protobuf, builds the Node wrapper)
+invoke build
+
+# 4. Run the Electron acceptance tests
+robot atest/test/01_Browser_Management/electron.robot
+```
+
+The `DISPLAY` variable must be set in the same shell that runs `robot`.
 
 ### Platform notes
 
-| Platform | Electron binary path (after `npm install`) |
-|----------|--------------------------------------------|
-| Linux | `node/electron-test-app/node_modules/.bin/electron` |
-| macOS | `node/electron-test-app/node_modules/.bin/electron` |
-| Windows | `node/electron-test-app/node_modules/.bin/electron.cmd` |
+| Platform | Electron binary path (after `npm install`) | Virtual display needed? |
+|----------|--------------------------------------------|------------------------|
+| Linux    | `node/electron-test-app/node_modules/.bin/electron` | Yes — Xvfb or Xvnc |
+| macOS    | `node/electron-test-app/node_modules/.bin/electron` | No                    |
+| Windows  | `node/electron-test-app/node_modules/.bin/electron.cmd` | No               |
+
+### What the test suite setup does
+
+The Robot Framework suite setup in `electron.robot` performs the following steps
+automatically before any test case runs:
+
+1. Detects the current platform (`sys.platform`).
+2. Runs `npm install` in `node/electron-test-app/` to download the Electron
+   binary for that platform.
+3. Resolves the correct binary path for the platform and stores it in
+   `${ELECTRON_BIN}`.
 
-Tests that cover UI interactions work on all three platforms.  Tests that use
-`Open Electron Dev Tools` require a display; on headless CI agents this keyword
-is called but its visible effect is not asserted.
+No manual setup beyond providing a `DISPLAY` on headless Linux is required.

node/playwright-wrapper/playwright-state.ts

@@ -896,13 +896,13 @@ export async function newPersistentContext(
     return response;
 }
 
-// ─────────────────────────────────────────────────────────────────────────────
-// Electron support — the following functions were written with AI assistance
-// (Claude by Anthropic) under the supervision of the contributor.
-// The contributor is the copyright holder for this section; the Robot Framework
-// Foundation copyright in the file header does not extend to AI-generated code.
-// ─────────────────────────────────────────────────────────────────────────────
 
+// NOTE: The launchElectron, closeElectron, and openElectronDevTools functions below
+// were contributed by an external contributor with AI assistance and are NOT covered
+// by the Robot Framework Foundation copyright at the top of this file.
+// SPDX-SnippetBegin
+// SPDX-SnippetCopyrightText: Contributors to the robotframework-browser project
+// SPDX-License-Identifier: Apache-2.0
 export async function launchElectron(
     request: Request.ElectronLaunch,
     openBrowsers: PlaywrightState,
@@ -985,6 +985,7 @@ export async function openElectronDevTools(openBrowsers: PlaywrightState): Promi
     });
     return emptyWithLog('Opened DevTools for all Electron windows');
 }
+// SPDX-SnippetEnd
 
 export async function connectToBrowser(
     request: Request.ConnectBrowser,