From 2afaf23e2c2ee75d54bdd222c00eae5ffb4a4491 Mon Sep 17 00:00:00 2001
From: Rockford Lhotka <rocky@lhotka.net>
Date: Thu, 26 Feb 2026 01:21:16 -0600
Subject: [PATCH] Fix CI test logger failure on .NET 10 / vstest 18
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

GitHubActionsTestLogger 2.x uses the legacy VSTest extension discovery
mechanism which no longer works with vstest 18.0.1 shipped in the .NET 10
SDK. Switch to v3.0.1, which targets Microsoft.Testing.Platform (MTP) and
auto-registers via TestingPlatformBuilderHook — no explicit --logger flag
required.

- Add tests/Directory.Build.props to enable UseMicrosoftTestingPlatformRunner
  and include GitHubActionsTestLogger in all test projects (chains to root
  Directory.Build.props)
- Bump GitHubActionsTestLogger to 3.0.1 in Directory.Packages.props
- Remove --logger "github;..." from the CI test step (auto-registered by MTP)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .github/workflows/ci.yml    |  2 +-
 Directory.Packages.props    |  1 +
 tests/Directory.Build.props | 14 ++++++++++++++
 3 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 tests/Directory.Build.props

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index ca102bf..a31cbaf 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -27,4 +27,4 @@ jobs:
         run: dotnet build --no-restore --configuration Release
 
       - name: Test
-        run: dotnet test --no-build --configuration Release --logger "github;summary.includePassedTests=true;summary.includeSkippedTests=true"
+        run: dotnet test --no-build --configuration Release
diff --git a/Directory.Packages.props b/Directory.Packages.props
index 8839216..fd2ea2a 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -26,6 +26,7 @@
     <PackageVersion Include="Microsoft.AspNetCore.OpenApi" Version="10.0.3" />
     <PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.3" />
     <!-- Testing -->
+    <PackageVersion Include="GitHubActionsTestLogger" Version="3.0.1" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
     <PackageVersion Include="NSubstitute" Version="5.3.0" />
     <PackageVersion Include="xunit" Version="2.9.3" />
diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props
new file mode 100644
index 0000000..6b87155
--- /dev/null
+++ b/tests/Directory.Build.props
@@ -0,0 +1,14 @@
+<Project>
+  <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
+
+  <PropertyGroup>
+    <UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="GitHubActionsTestLogger">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
+  </ItemGroup>
+</Project>