Unification of terminal logs

[mwlasiuk]

Currently project uses multiple ways of logging data to the terminal:

• recently introduced spdlog : Add spdlog logging and UTL profiling to lidar odometry hot path #328
• cout / cerr
• fprintf (mostly in LAZ related sources)

Would be nice to establish one method and stick to it for the future as currently it is annoying (and printf specifiers are not portable and generate warnings on different systems that polute build logs making it difficult to find actual important warnings).

What should this project use for logging???

[yuckinus]

I thought the decision was already made to switch to spdlog, I even tried to help and also implemented it in viewers and calibrator. All that was left was the steps apps fully not just odometry part

[JanuszBedkowski]

spdlog

[mwlasiuk]

spdlog

Is there any active work on that @yuckinus / @JanuszBedkowski or should I take this task?

[yuckinus]

I changed what I could in viewers, calibration and step2 main cpp. You can take it over and change in step1/3, core, etc

I can also do it but can't say for sure when

[JanuszBedkowski]

closed due to no activty

[michalpelka]

@JanuszBedkowski please, close those issues as completed. To me signal is: there is unification of logging in project what is not true.

Use "Close as not planed" if you really want to close incomplete issue:

Also I do not understand why you are closing issues that are tasks to do. In mature project, large project, those should be opened to give contributors clue what to do.
Also closing issue that has assignee, should be consulted.

[yuckinus]

I agree with Michal on this one if it counts..

[JanuszBedkowski]

completed.

Each issue has Time of Live, You can always reopen and implement fix.