Can now access elements from svg by id

Author: henrikmidtiby

manim/mobject/svg/svg_mobject.py

@@ -127,6 +127,7 @@ def __init__(
         self.stroke_color = stroke_color
         self.stroke_opacity = stroke_opacity  # type: ignore[assignment]
         self.stroke_width = stroke_width  # type: ignore[assignment]
+        self.id_to_vgroup_dict: dict[str, VGroup] = {}
         if self.stroke_width is None:
             self.stroke_width = 0
 
@@ -205,9 +206,11 @@ def generate_mobject(self) -> None:
         svg = se.SVG.parse(modified_file_path)
         modified_file_path.unlink()
 
+        mobjects_dict = self.get_mobjects_from(svg)
+        for key, value in mobjects_dict.items():
+            self.id_to_vgroup_dict[key] = value
+            self.add(value)
 
-        mobjects = self.get_mobjects_from(svg)
-        self.add(*mobjects)
         self.flip(RIGHT)  # Flip y
 
     def get_file_path(self) -> Path:
@@ -261,7 +264,7 @@ def generate_config_style_dict(self) -> dict[str, str]:
                 result[svg_key] = str(svg_default_dict[style_key])
         return result
 
-    def get_mobjects_from(self, svg: se.SVG) -> list[VMobject]:
+    def get_mobjects_from(self, svg: se.SVG) -> dict[str, VGroup]:
         print("<get_mobjects_from>")
         """Convert the elements of the SVG to a list of mobjects.
 
@@ -290,47 +293,33 @@ def get_mobjects_from(self, svg: se.SVG) -> list[VMobject]:
                 group_id_number += 1
                 pass
             if isinstance(element, se.Group):
-                print("  " * depth, f"create a vgroup with the name: '{ group_name }'")
+                print("  " * depth, f"create a vgroup with the name: '{group_name}'")
                 vg = VGroup()
                 vgroups[group_name] = vg
                 vgroup_names.append(group_name)
                 vgroup_stack.append(group_name)
-                print("  " * depth, "depth: %d" % depth)
-                print("  " * depth, "vgroup_stack: ", vgroup_stack)
                 parent_name = vgroup_stack[depth - 1]
-                print("  " * depth, "parent_name: '%s'" % parent_name)
                 vgroups[parent_name].add(vgroups[group_name])
-                print("  " * depth, "Added to vgroup '%s'" % parent_name)
 
             if isinstance(element, (se.Group, se.Use)):
                 for subelement in element[::-1]:
                     stack.append((subelement, depth + 1))
             # Add element to the parent vgroup
             try:
                 parent_name = vgroup_stack[depth - 2]
-                print("  " * depth, "parent: ", parent_name)
-                if isinstance(element, se.Path):
-                    mob: VMobject = self.path_to_mobject(element)
-                    self.apply_style_to_mobject(mob, element)
-                    if isinstance(element, se.Transformable) and element.apply:
-                        self.handle_transform(mob, element.transform)
+                if isinstance(element, (se.Path)):
+                    mob = self.get_mob_from_shape_element(element)
                     vgroups[parent_name].add(mob)
-                    print(
-                        "  " * depth,
-                        "vgroups['%s']" % parent_name,
-                        vgroups[parent_name],
-                    )
-                    print("  " * depth, "Added to vgroup '%s'" % parent_name)
 
             except Exception as e:
                 print(e)
                 print("depth: ", depth)
 
-        return vgroups["root"], vgroups
+        return vgroups
 
-    def get_mob_from_shape_element(self, shape):
+    def get_mob_from_shape_element(self, shape: se.SVGElement) -> VMobject:
         if isinstance(shape, se.Group):  # noqa: SIM114
-            assert False, "Should never get here"
+            raise Exception("Should never get here")
         elif isinstance(shape, se.Path):
             mob: VMobject = self.path_to_mobject(shape)
         elif isinstance(shape, se.SimpleLine):
@@ -346,12 +335,12 @@ def get_mob_from_shape_element(self, shape):
         elif isinstance(shape, se.Text):
             mob = self.text_to_mobject(shape)
         elif isinstance(shape, se.Use) or type(shape) is se.SVGElement:
-            assert False, "Should never get here - se.Use or se.SVGElement"
+            raise Exception("Should never get here - se.Use or se.SVGElement")
         else:
             logger.warning(f"Unsupported element type: {type(shape)}")
-            assert False, f"Unsupported element type: {type(shape)}"
+            raise Exception(f"Unsupported element type: {type(shape)}")
         if mob is None or not mob.has_points():
-            assert False, f"mob is empty or have no points"
+            raise Exception("mob is empty or have no points")
         self.apply_style_to_mobject(mob, shape)
         if isinstance(shape, se.Transformable) and shape.apply:
             self.handle_transform(mob, shape.transform)