Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

Commit ebf631e

Browse files
committed
fix: Change default protocol version to 3
1 parent 1253a50 commit ebf631e

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

inc/DoIPMessage.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ constexpr uint8_t ISO_13400_2025 = 4;
4343
/**
4444
* @brief Current protocol version (table 16)
4545
*/
46-
constexpr uint8_t PROTOCOL_VERSION = ISO_13400_2025;
47-
constexpr uint8_t PROTOCOL_VERSION_INV = static_cast<uint8_t>(~ISO_13400_2025);
46+
constexpr uint8_t PROTOCOL_VERSION = ISO_13400_2019;
47+
constexpr uint8_t PROTOCOL_VERSION_INV = static_cast<uint8_t>(~PROTOCOL_VERSION);
4848

4949
/**
5050
* @brief Positive ack for diagnostic message (table 24)

test/DoIPMessage_Test.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ TEST_SUITE("DoIPMessage") {
88
TEST_CASE("Message assembly") {
99
DoIPMessage msg(DoIPPayloadType::AliveCheckRequest, {0x01, 0x02});
1010
ByteArray expected{
11-
0x04, 0xfb, // protocol version + inv
11+
0x03, 0xfc, // protocol version + inv
1212
0x00, 0x07, // payload type
1313
0x00, 0x00, 0x00, 0x02, // payload length
1414
0x01, 0x02 // payload
@@ -28,7 +28,7 @@ TEST_SUITE("DoIPMessage") {
2828
TEST_CASE("Message factory - makeNegativeAckMessage") {
2929
DoIPMessage msg = message::makeNegativeAckMessage(DoIPNegativeAck::InvalidPayloadLength);
3030
ByteArray expected{
31-
0x04, 0xfb, // protocol version + inv
31+
0x03, 0xfc, // protocol version + inv
3232
0x00, 0x00, // payload type
3333
0x00, 0x00, 0x00, 0x01, // payload length
3434
0x04 // payload
@@ -42,7 +42,7 @@ TEST_SUITE("DoIPMessage") {
4242
TEST_CASE("Message factory - makeDiagnosticMessage") {
4343
DoIPMessage msg = message::makeDiagnosticMessage(DoIPAddress(0xcafe), DoIPAddress(0xbabe), {0xde, 0xad, 0xbe, 0xef});
4444
ByteArray expected{
45-
0x04, 0xfb, // protocol version + inv
45+
0x03, 0xfc, // protocol version + inv
4646
0x80, 0x01, // payload type
4747
0x00, 0x00, 0x00, 0x08, // payload length
4848
0xca, 0xfe, // sa
@@ -63,7 +63,7 @@ TEST_SUITE("DoIPMessage") {
6363
TEST_CASE("Message factory - makeDiagnosticPositiveResponse") {
6464
DoIPMessage msg = message::makeDiagnosticPositiveResponse(DoIPAddress(0xcafe), DoIPAddress(0xbabe), {0xde, 0xad, 0xbe, 0xef});
6565
ByteArray expected{
66-
0x04, 0xfb, // protocol version + inv
66+
0x03, 0xfc, // protocol version + inv
6767
0x80, 0x02, // payload tyByteArray raw = message::makeAliveCheckResponse(DoIPAddress(0xa0b0));pe
6868
0x00, 0x00, 0x00, 0x09, // payload length
6969
0xca, 0xfe, // sa
@@ -90,7 +90,7 @@ TEST_SUITE("DoIPMessage") {
9090
{0xde, 0xad, 0xbe, 0xef});
9191

9292
ByteArray expected{
93-
0x04, 0xfb, // protocol version + inv
93+
0x03, 0xfc, // protocol version + inv
9494
0x80, 0x03, // payload type
9595
0x00, 0x00, 0x00, 0x09, // payload length
9696
0xca, 0xfe, // sa
@@ -120,7 +120,7 @@ TEST_SUITE("DoIPMessage") {
120120
TEST_CASE("Message factory - makeAliveCheckResponse") {
121121
DoIPMessage msg = message::makeAliveCheckResponse(DoIPAddress(0xa0b0));
122122
ByteArray expected{
123-
0x04, 0xfb, // protocol version + inv
123+
0x03, 0xfc, // protocol version + inv
124124
0x00, 0x08, // payload type
125125
0x00, 0x00, 0x00, 0x02, // payload length
126126
0xa0, 0xb0, // sa

0 commit comments

Comments
 (0)