Bug for soil initialization in MPAS/NoahMP

[cenlinhe]

The following code in the current MPAS/NoahMP initialization part is wrong:
mpas_noahmp%sh2o(i,ns) = sh2o(ns,i)
mpas_noahmp%smois(i,ns) = smois(ns,i)
mpas_noahmp%tslb(i,ns) = tslb(ns,i)

The code is here:

MPAS-Model/src/core_atmosphere/physics/mpas_atmphys_lsm_noahmpinit.F

Lines 422 to 424 in 41e9a3f

	mpas_noahmp%sh2o(i,ns) = sh2o(ns,i)
	mpas_noahmp%smois(i,ns) = smois(ns,i)
	mpas_noahmp%tslb(i,ns) = tslb(ns,i)

The current code leads to a wrongly initialized soil temperature and moisture field.

The correct code should be as follows:
sh2o(ns,i) = mpas_noahmp%sh2o(i,ns)
smois(ns,i) = mpas_noahmp%smois(i,ns)
tslb(ns,i) = mpas_noahmp%tslb(i,ns)

This bug needs to be fixed as soon as possible.

[cenlinhe]

@CharlesZheZhang @barlage
@CharlesZheZhang Could you please submit a PR for this? thanks!

[CharlesZheZhang]

Hi Cenlin,

This PR (#1244) already fixed this issue and has been merged to hotfix-v8.2.3.

I created this new PR (#1311) to remove the redundant lines from (L398-433)
https://github.com/ldfowler58/MPAS-Model/blob/4ba48ba7f0bc7653da811a6ab54e5ce3cd1402b4/src/core_atmosphere/physics/mpas_atmphys_lsm_noahmpinit.F#L398

[cenlinhe]

OK, thanks for the clarification. I am going to close this issue.