Fix varying parameters used for inferred length (#33)

* Add flaky test for inferred length in doc string

The parameter used for inferring the length is not deterministic because of the non-determinism of hash set. This leads to changing logic between builds, shown by this flaky test.

* Switch to deterministic parameter

Use the first parameter for inferring the length as intended by the code

Author: delreluca

MKL.NET.WrapperGenerator.Tests/GeneratorTest.cs

@@ -49,7 +49,10 @@ public static unsafe extern void dummy(int M, int N,
 
         generatorResult.Generator.Should().BeSameAs(generator);
         generatorResult.Diagnostics.Should().BeEmpty();
-        generatorResult.GeneratedSources.Should().HaveCount(1);
+        generatorResult.GeneratedSources.Should().ContainSingle()
+            .Which.SourceText.ToString().Should().Contain(
+                "///<remarks>" +
+                "This version infers the length parameter <c>N</c> from <paramref name=\"A\" />'s length.</remarks>");
         generatorResult.Exception.Should().BeNull();
     }
 

MKL.NET.WrapperGenerator/WrapperGenerator.cs

@@ -36,10 +36,10 @@ public void Initialize(GeneratorInitializationContext context)
         return candidates[0];
     }
 
-    private static (ISet<ParameterSyntax> changed, ParameterListSyntax newList)
+    private static (IList<ParameterSyntax> changed, ParameterListSyntax newList)
     TransformParameters(MethodDeclarationSyntax mds, Func<ParameterSyntax, ParameterSyntax?> f)
     {
-        var changed = mds.ParameterList.Parameters.Select(ps => f(ps) is null ? null : ps).Where(ps => ps != null).ToImmutableHashSet();
+        var changed = mds.ParameterList.Parameters.Select(ps => f(ps) is null ? null : ps).Where(ps => ps != null).ToImmutableList();
         var newList = SyntaxFactory.ParameterList(SyntaxFactory.SeparatedList(mds.ParameterList.Parameters.Select(ps => f(ps) ?? ps)));
 
         return (changed!, newList);
@@ -57,7 +57,7 @@ private enum AdditionalTransformation
 
     void WriterTransformedMethod(
         MethodDeclarationSyntax mds, ClassDeclarationSyntax nativeCds,
-        (ISet<ParameterSyntax> changed, ParameterListSyntax newList) transformation, StringBuilder sb,
+        (IList<ParameterSyntax> changed, ParameterListSyntax newList) transformation, StringBuilder sb,
         AdditionalTransformation trafo)
     {
         (ParameterSyntax lengthParam, string takeLengthFrom)? lengthOptions = null;