Syntax highlighting changed after update to 3.16.2

[csaar95]

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

MacOS

What is the issue affecting?

Other

Expected Behaviour

Actual Behaviour

Reproduction steps

1. Open Lua file.
2. Define e. g. a lua table with functions inside.

Additional Notes

No response

Log File

No response

[csaar95]

I currently switched back to 3.16.1. Is this behavior intentional?

[johannesrld]

That is not correct syntax, you need three --- for the language server to properly interpret ---@params.

[tomlau10]

I just did a little testing, and I found that the highlight in your Expected Behaviour is done by vscode itself, not LuaLS. 😕
When I disable LuaLS, the highlight becomes the one in Expected Behaviour.

While @johannesrld is true that those @param annotation should be prefixed with triple dash --- to work with LuaLS 👍
but if you prefer the highlight in your Expected Behaviour, you can set the semantic.enable config to false:

• Disabling Syntax highlighting in annotated comments #3081 (comment)

=> this disables LuaLS's own syntax highlight, and use the default highlighting of vscode 🤔

[csaar95]

@tomlau10 @johannesrld

The problem is not the behavior of the comments, but that functions within objects can no longer be distinguished from normal table fields.

[csaar95]

In addition, it seems to be a problem with CPU usage again in one of the newer versions (permanently at 100% with version 3.16.4).

In this case running as vscode server on Rocky Linux 8.10.

[CppCXY]

The performance of luals itself can't really be considered very good. Moreover, many community-contributed patches haven't given careful thought to performance, and this situation is likely to persist for a long time.

Regarding your original question, I think it’s related to semantic tokens — it’s possible that some updates caused ordinary comments to be assigned semantic tokens.