Skip to content

Commit 1818b67

Browse files
authored
Enhance comments in update-path.bat
Add comments regarding registry command behavior on Chinese Windows systems.
1 parent f8ce4d1 commit 1818b67

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src_assets/windows/misc/path/update-path.bat

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ if /i "%~1"=="remove" (
9494
rem Only update if path was changed
9595
if "!CHANGES_MADE!"=="1" (
9696
rem Set the new path in the registry
97+
rem Windows systems running Chinese may unexpectedly ignore the /f option at the end of the command.
98+
rem This issue only occurs with the remove command.
9799
reg add "%KEY_NAME%" /v "%VALUE_NAME%" /t REG_EXPAND_SZ /f /d "!CURRENT_PATH!"
98100
if !ERRORLEVEL!==0 (
99101
echo Successfully removed Sunshine directories from PATH

0 commit comments

Comments
 (0)