Refactor OpenSSL flags; update CI & clang-format

Split the long OPENSSL_CPPFLAGS string into a readable list (OPENSSL_CPPFLAGS_LIST) and join it back into OPENSSL_CPPFLAGS to simplify maintenance. Add a cmake-lint disable comment for OpenSSL_FOUND. Adjust the GitHub Actions step condition to use `false && always()` (keeps the step disabled while evaluating always()). Remove the explicit LineEnding setting from .clang-format.

Author: ReenigneArcher

.clang-format

@@ -69,7 +69,6 @@ IndentWrappedFunctionNames: true
 InsertBraces: true
 InsertNewlineAtEOF: true
 KeepEmptyLinesAtTheStartOfBlocks: false
-LineEnding: LF
 MaxEmptyLinesToKeep: 1
 NamespaceIndentation: All
 ObjCBinPackProtocolList: Never

.github/workflows/ci.yml

@@ -155,7 +155,7 @@ jobs:
 
       - name: Run tests
         id: test
-        if: false
+        if: false && always()
         working-directory: build/tests
         run: ./test_moonlight --gtest_color=yes --gtest_output=xml:test_results.xml
 

cmake/modules/GetOpenSSL.cmake

@@ -20,8 +20,22 @@ endif()
 find_program(PERL_EXECUTABLE perl REQUIRED)
 find_program(OPENSSL_MAKE_EXECUTABLE NAMES make REQUIRED)
 
-set(OPENSSL_CPPFLAGS
-        "-UWIN32 -U_WIN32 -DNO_SYSLOG -DOPENSSL_NO_SYSLOG -D_exit=_Exit -I${NXDK_DIR}/lib -I${NXDK_DIR}/lib/xboxrt/libc_extensions -I${NXDK_DIR}/lib/pdclib/include -I${NXDK_DIR}/lib/pdclib/platform/xbox/include -I${NXDK_DIR}/lib/winapi -I${NXDK_DIR}/lib/xboxrt/vcruntime -I${NXDK_DIR}/lib/net/lwip/src/include -I${NXDK_DIR}/lib/net/nforceif/include")
+set(OPENSSL_CPPFLAGS_LIST
+        -UWIN32
+        -U_WIN32
+        -DNO_SYSLOG
+        -DOPENSSL_NO_SYSLOG
+        -D_exit=_Exit
+        "-I${NXDK_DIR}/lib"
+        "-I${NXDK_DIR}/lib/xboxrt/libc_extensions"
+        "-I${NXDK_DIR}/lib/pdclib/include"
+        "-I${NXDK_DIR}/lib/pdclib/platform/xbox/include"
+        "-I${NXDK_DIR}/lib/winapi"
+        "-I${NXDK_DIR}/lib/xboxrt/vcruntime"
+        "-I${NXDK_DIR}/lib/net/lwip/src/include"
+        "-I${NXDK_DIR}/lib/net/nforceif/include"
+)
+list(JOIN OPENSSL_CPPFLAGS_LIST " " OPENSSL_CPPFLAGS)
 
 set(OPENSSL_ENV
         ${CMAKE_COMMAND} -E env
@@ -79,7 +93,7 @@ ExternalProject_Add(openssl_external
         PATCH_COMMAND ""
 )
 
-set(OpenSSL_FOUND TRUE)
+set(OpenSSL_FOUND TRUE)  # cmake-lint: disable=C0103
 set(OPENSSL_INCLUDE_DIR "${OPENSSL_INSTALL_DIR}/include")
 set(OPENSSL_CRYPTO_LIBRARY "${OPENSSL_INSTALL_DIR}/lib/libcrypto.a")
 set(OPENSSL_SSL_LIBRARY "${OPENSSL_INSTALL_DIR}/lib/libssl.a")