refactor: fix some sonar issues

Author: ReenigneArcher

_includes/donate.html

@@ -3,9 +3,7 @@
     <div class="container mb-5 shadow border-0 card-custom rounded-0">
         <div class="d-table-row g-0">
             <div class="d-table-cell px-3 align-middle text-center">
-                <h1>
-                    <i class="fa-fw fas fa-coins"></i>
-                </h1>
+                <i class="fa-fw fa-2xl fas fa-coins"></i>
             </div>
             <div class="col-sm-auto border-white my-3 px-3 py-2 border-start">
                 <div class="container">

_includes/license-entries.html

@@ -0,0 +1,17 @@
+<ul class="list-group list-group-flush">
+    {% for license in site.data.licenses %}
+    {% assign item = license[1] %}
+    <li class="list-group-item license-entry-item crowdin-ignore">
+        <div class="d-flex justify-content-between align-items-center crowdin-ignore">
+            <div>
+                <strong class="crowdin-ignore">{{ item.name }}</strong>
+                {% if item.version %}<span class="ms-2 badge bg-secondary crowdin-ignore">{{ item.version }}</span>{% endif %}
+                <small class="d-block license-entry-text-muted crowdin-ignore">
+                    <a href="{{ item.url }}" target="_blank" class="license-entry-link crowdin-ignore">{{ item.url }}</a>
+                </small>
+            </div>
+            <span class="badge bg-primary crowdin-ignore">{{ item.license }}</span>
+        </div>
+    </li>
+    {% endfor %}
+</ul>

_includes/license-entry.html

@@ -15,9 +15,9 @@
     {
         if (!document.getElementsByTagName) return false;
         let links = document.getElementsByTagName("a");
-        for (let eleLink=0; eleLink < links.length; eleLink ++) {
-            if ((links[eleLink].href.indexOf('.pdf') !== -1)||(links[eleLink].href.indexOf('.doc') !== -1)||(links[eleLink].href.indexOf('.docx') !== -1)) {
-                links[eleLink].onclick =
+        for (const element of links) {
+            if (element.href.includes('.pdf') || element.href.includes('.doc') || element.href.includes('.docx')) {
+                element.onclick =
                 function() {
                     window.open(this.href);
                     return false;

_includes/open-in-new-window.html

@@ -43,6 +43,7 @@
   width: 100%;
   height: 100%;
   background: none;
+  border-color: #0d6efd;
   border-width: 5px;
   border-style: solid;
   position: absolute;
@@ -92,10 +93,6 @@
   line-height: 0.5;
 }
 
-.circular-button .progress-bar {
-  border-color: #0d6efd;
-}
-
 .circular-button.active .button-content {
   box-shadow: 0 0 10px 3px rgba(13, 110, 253, 0.5);
 }

_sass/circular-progress.scss

@@ -1 +1 @@
-window.initCrowdIn('LizardByte', null);
+globalThis.initCrowdIn('LizardByte', null);

assets/js/crowdin-init.js

@@ -1,6 +1,6 @@
 document.addEventListener('DOMContentLoaded', function() {
     const gamepadHelper = new GamepadHelper()
-    const gamepadHelperVersion = window.gamepadHelperVersion;
+    const gamepadHelperVersion = globalThis.gamepadHelperVersion;
     let gamepads = {};
     let activeGamepadIndex = null;
     let animationFrameId = null;
@@ -21,7 +21,7 @@ document.addEventListener('DOMContentLoaded', function() {
     const themeObserver = new MutationObserver(function(mutations) {
         mutations.forEach(function(mutation) {
             if (mutation.type === 'attributes' && mutation.attributeName === 'data-bs-theme') {
-                // Theme changed, reinitialize buttons with new color scheme
+                // Theme changed, reinitialize buttons with a new color scheme
                 if (activeGamepadIndex !== null) {
                     initGamepadButtons();
                 }
@@ -36,7 +36,7 @@ document.addEventListener('DOMContentLoaded', function() {
     });
 
     // Setup gamepad event listeners
-    window.addEventListener("gamepadconnected", function(e) {
+    globalThis.addEventListener("gamepadconnected", function(e) {
         gamepads[e.gamepad.index] = e.gamepad;
 
         // Always activate the newly connected gamepad
@@ -51,7 +51,7 @@ document.addEventListener('DOMContentLoaded', function() {
         }
     });
 
-    window.addEventListener("gamepaddisconnected", function(e) {
+    globalThis.addEventListener("gamepaddisconnected", function(e) {
         delete gamepads[e.gamepad.index];
         updateGamepadSelector();
 
@@ -76,7 +76,7 @@ document.addEventListener('DOMContentLoaded', function() {
         const card = e.target.closest('.gamepad-selector-card');
         if (card) {
             activeGamepadIndex = Number.parseInt(card.dataset.index);
-            updateGamepadSelector(); // Re-render to update active state
+            updateGamepadSelector(); // Re-render to update the active state
             initGamepadButtons();
             initGamepadAxes();
         }
@@ -176,7 +176,7 @@ document.addEventListener('DOMContentLoaded', function() {
 
         const controllerType = gamepadHelper.detectControllerType(gamepad.id);
 
-        // Detect current theme - use Black icons for light theme, White icons for dark theme
+        // Detect the current theme - use Black icons for the light theme, White icons for the dark theme
         const isDarkTheme = document.documentElement.dataset.bsTheme === 'dark';
         const colorScheme = isDarkTheme ? 'White' : 'Black';
 
@@ -206,7 +206,7 @@ document.addEventListener('DOMContentLoaded', function() {
             const buttonContent = document.createElement('div');
             buttonContent.className = 'button-content';
 
-            // Add either image with fallback text, or just text
+            // Add either image with fallback text or just text
             if (buttonImagePath) {
                 buttonContent.innerHTML = `
                 <div class="button-image-container">
@@ -318,7 +318,7 @@ document.addEventListener('DOMContentLoaded', function() {
         vibrationStatus.innerHTML = `<span class="badge bg-success">Supported</span> Actuator type: <span class="badge bg-secondary">${vibrationCapabilities.type}</span>`;
         vibrationButtons.classList.remove('d-none');
 
-        // Show appropriate controls based on actuator type
+        // Show appropriate controls based on an actuator type
         if (vibrationCapabilities.type === 'dual-rumble') {
             dualRumbleControls.classList.remove('d-none');
         } else {
@@ -357,12 +357,12 @@ document.addEventListener('DOMContentLoaded', function() {
                     // Only the right side rotates for the first half
                     progressBarRightElement.style.transform = `rotate(${degrees}deg)`;
                 } else {
-                    // Right side is at full rotation, left side rotates for the remainder
+                    // The right side is at full rotation, the left side rotates for the remainder
                     progressBarRightElement.style.transform = 'rotate(180deg)';
                     progressBarLeftElement.style.transform = `rotate(${degrees - 180}deg)`;
                 }
 
-                // Add/remove active class based on button state
+                // Add/remove the active class based on the button state
                 if (isPressed) {
                     buttonElement.classList.add('active');
                 } else {
@@ -388,7 +388,7 @@ document.addEventListener('DOMContentLoaded', function() {
                 const progressWidth = ((axisValue + 1) / 2) * 100;
                 axisProgressElement.style.width = `${progressWidth}%`;
 
-                // Change color based on direction
+                // Change color based on the direction
                 if (axisValue > 0.1) {
                     axisProgressElement.classList.remove('bg-info', 'bg-danger');
                     axisProgressElement.classList.add('bg-success');
@@ -506,7 +506,7 @@ document.addEventListener('DOMContentLoaded', function() {
     function startGamepadLoop() {
         if (animationFrameId) return;
 
-        // Make sure UI elements are initialized when starting loop
+        // Make sure UI elements are initialized when starting the loop
         if (activeGamepadIndex !== null) {
             initGamepadButtons();
             initGamepadAxes();

assets/js/discord-init.js

@@ -32,7 +32,7 @@ $(document).ready(function(){
         type: "GET",
         dataType:"json",
         success: function (result) {
-            let sorted = result.sort(window.rankingSorter("stargazers_count", "name"))
+            let sorted = result.sort(globalThis.rankingSorter("stargazers_count", "name"))
 
             for(let repo in sorted) {
                 let process_repo = true;
@@ -175,7 +175,7 @@ $(document).ready(function(){
                     star_link.className = "nav-link nav-link-sm project-nav-link ms-3 crowdin-ignore"
                     star_link.href = `https://star-history.com/#${sorted[repo]['full_name']}`
                     star_link.target = "_blank"
-                    star_link.textContent = window.formatNumber(sorted[repo]['stargazers_count'])
+                    star_link.textContent = globalThis.formatNumber(sorted[repo]['stargazers_count'])
                     repo_data_row.appendChild(star_link)
 
                     let star_link_image = document.createElement("i")
@@ -186,7 +186,7 @@ $(document).ready(function(){
                     fork_link.className = "nav-link nav-link-sm project-nav-link ms-3 crowdin-ignore"
                     fork_link.href = `https://github.com/${sorted[repo]['full_name']}/network/members`
                     fork_link.target = "_blank"
-                    fork_link.textContent = window.formatNumber(sorted[repo]['forks'])
+                    fork_link.textContent = globalThis.formatNumber(sorted[repo]['forks'])
                     repo_data_row.appendChild(fork_link)
 
                     let fork_link_image = document.createElement("i")
@@ -208,7 +208,7 @@ $(document).ready(function(){
                                     continue;
                                 }
                             } catch (e) {
-                                console.error("Invalid URL:", docs_url);
+                                console.error("Invalid URL:", docs_url, e);
                                 continue;
                             }
 

assets/js/gamepad-tester.js

@@ -11,7 +11,7 @@
   - /assets/js/gamepad-tester.js
 ---
 <script>
-    window.gamepadHelperVersion = "{{ site.data.licenses.gamepad-helper.version }}";
+    globalThis.gamepadHelperVersion = "{{ site.data.licenses.gamepad-helper.version }}";
 </script>
 
 <!-- Gamepad Tester section -->