Selecting the "Turn on clients" button the procedure don't send the WOL packet to the clients

[agostinimarco]

Describe the bug
After configured mac address to enable the WOL feature, when I select the "Turn on clients" button the procedure don't send the WOL packet to the clients.

To Reproduce
Steps to reproduce the behavior:

1. Configure the lists of mac address in "More / Settings / Client Power Options"
2. Click on 'Turn on clients'
3. tail /var/log/libki/libki.log
4. See error 'Can't call method "setting" on an undefined value at /home/libki/libki-server/lib/Libki/Clients.pm line 53.'
5. Using tcpdump to try to catch WOL packet nothing appears

Expected behavior
WOL packet sended to all clients in the list

Deployment architecture:

• Linux Debian 12
• Deployment style LAMP
• Versions of software used Libki 4.9.1

Desktop (please complete the following information):

• Linux Mint XFCE
• Version 22

Additional context
I resolved the issue modifying the file /home/libki/libki-server/lib/Libki/Clients.pm at row 21.
This is a diff with the version without error and the original version of the file.

# diff /home/libki/libki-server/lib/Libki/Clients.pm /home/libki/libki-server/lib/Libki/Clients.pm.original
21c21
<     my @mac_addresses = get_wol_mac_addresses($c);
---
>     my @mac_addresses = get_wol_mac_addresses();

As you can see, the get_wol_mac_addresses() function expects a parameter that is not defined in the original file.

It's possible to apply this patch for the future release of libki server ?

Thank's in advance and compliments for this incredible project.

[sekjal]

Looks like this was resolved with along with issue #402; the code now sports the $c parameter to get_wol_mac_addresses() in lib/Libki/Clients.pm