feat: enhance identity search filtering logic

- Updated the identity search filter to exclude identities marked as "do not sync" by default, unless a specific state filter is provided by the client.
- Introduced a new variable `effectiveSearchFilterSchema` to manage the search filter schema, ensuring compatibility with MongoDB operators while maintaining type safety.

Author: tacxou

apps/api/src/management/identities/identities-crud.controller.ts

@@ -173,16 +173,24 @@ export class IdentitiesCrudController extends AbstractController {
     validations?: MixedValue;
   }>> {
     const searchFilter = {}
+    // Par défaut, on cache les identités "ne pas synchroniser" dans la recherche.
+    // Si le client fournit déjà un filtre `state`, on ne l'écrase pas.
+    // Le type `FilterSchema` est récursif (valeurs attendues), alors que pour Mongo on injecte parfois
+    // des opérateurs comme `{ $ne: ... }`. On garde un cast `any` ici côté controller.
+    const effectiveSearchFilterSchema: any = { ...searchFilterSchema }
+    if (!Object.prototype.hasOwnProperty.call(effectiveSearchFilterSchema, 'state')) {
+      effectiveSearchFilterSchema.state = { $ne: IdentityState.DONT_SYNC }
+    }
 
     if (search && search.trim().length > 0) {
       const searchRequest = {}
       searchRequest['$or'] = Object.keys(IdentitiesCrudController.searchFields).map((key) => {
         return { [key]: { $regex: `^${search}`, $options: 'i' } }
       }).filter(item => item !== undefined)
       searchFilter['$and'] = [searchRequest]
-      searchFilter['$and'].push(searchFilterSchema)
+      searchFilter['$and'].push(effectiveSearchFilterSchema)
     } else {
-      Object.assign(searchFilter, searchFilterSchema)
+      Object.assign(searchFilter, effectiveSearchFilterSchema)
     }
 
     const [data, total] = await this._service.findAndCount(