fix: enhance lifecycleChangedIdentities method to handle identity changes

#81

- Updated the lifecycleChangedIdentities method to accept a more complex payload structure, allowing for both before and after states of identities.
- Adjusted the logic to ensure proper handling of identity IDs and added checks for missing IDs.
- Modified the lifecycle hooks service to pass the new identity structure when calling lifecycleChangedIdentities, improving the clarity of identity updates.

Author: tacxou

apps/api/src/core/backends/backends.service.ts

@@ -248,16 +248,23 @@ export class BackendsService extends AbstractQueueProcessor {
     return result;
   }
 
-  public async lifecycleChangedIdentities(payload: string[], options?: ExecuteJobOptions): Promise<any> {
+  public async lifecycleChangedIdentities(
+    payload: (string | { id?: string; before?: Identities; after?: Identities })[],
+    options?: ExecuteJobOptions,
+  ): Promise<any> {
     const identities: {
       action: ActionType;
+      before?: Identities;
       identity: Identities;
     }[] = [];
 
     if (!payload.length) throw new BadRequestException('No identities to sync');
 
-    for (const key of payload) {
-      const identity = await this.identitiesService.findById<any>(key);
+    for (const item of payload) {
+      const before = typeof item === 'string' ? undefined : item.before;
+      const identityId = typeof item === 'string' ? item : (item.after?._id?.toString() || item.id);
+      if (!identityId) throw new BadRequestException('Missing identity id for lifecycle change');
+      const identity = (typeof item === 'string' || !item.after) ? await this.identitiesService.findById<any>(identityId) : item.after;
       // cas des fusion l employeeNumber doit etre celui de l identite primaire
       if (identity.primaryEmployeeNumber !== null && identity.primaryEmployeeNumber !== '') {
         identity.inetOrgPerson.employeeNumber = identity.primaryEmployeeNumber;
@@ -267,6 +274,7 @@ export class BackendsService extends AbstractQueueProcessor {
       }
       identities.push({
         action: ActionType.IDENTITY_LIFECYCLE_CHANGED,
+        before,
         identity,
       });
     }
@@ -277,7 +285,7 @@ export class BackendsService extends AbstractQueueProcessor {
 
     const result = {};
     for (const identity of identities) {
-      const [executedJob] = await this.executeJob(identity.action, identity.identity._id, identity.identity, {
+      const [executedJob] = await this.executeJob(identity.action, identity.identity._id, { before: identity.before, after: identity.identity }, {
         ...options,
         updateStatus: true,
         task: task._id as unknown as Types.ObjectId,

apps/api/src/management/lifecycle/lifecycle-hooks.service.ts

@@ -486,7 +486,7 @@ export class LifecycleHooksService extends AbstractLifecycleService {
           date: new Date(),
         })
 
-        const identities = res._id ? [res._id] : []
+        const identities = res._id ? [{ id: res._id.toString(), before: after, after: res }] : []
         await this.backendsService.lifecycleChangedIdentities(identities)
 
         this.logger.log(`Identity <${res._id}> updated to lifecycle <${lcs.target}> based on rules from source <${after.lifecycle}>`)
@@ -495,7 +495,7 @@ export class LifecycleHooksService extends AbstractLifecycleService {
     }
 
     if (lifecycleChanged) {
-      const identities = after._id ? [after._id] : []
+      const identities = after._id ? [{ id: after._id.toString(), before, after }] : []
       await this.backendsService.lifecycleChangedIdentities(identities)
     }
   }