refactor: improve lifecycle event handling in LifecycleHooksService

- Enhanced the fireLifecycleEvent method to introduce a lifecycleChanged variable for better readability and maintainability.
- Updated the logic to ensure lifecycle change events are processed correctly, including notifying backends of changed identities.

Author: tacxou

apps/api/src/management/lifecycle/lifecycle-hooks.service.ts

@@ -433,7 +433,9 @@ export class LifecycleHooksService extends AbstractLifecycleService {
    * // L'identité est automatiquement transitionnée vers MANUAL
    */
   private async fireLifecycleEvent(before: Identities, after: Identities): Promise<void> {
-    if (before.lifecycle !== after.lifecycle) {
+    const lifecycleChanged = !!before && before.lifecycle !== after.lifecycle
+
+    if (lifecycleChanged) {
       await this.create({
         refId: after._id,
         lifecycle: after.lifecycle,
@@ -491,5 +493,10 @@ export class LifecycleHooksService extends AbstractLifecycleService {
         return
       }
     }
+
+    if (lifecycleChanged) {
+      const identities = after._id ? [after._id] : []
+      await this.backendsService.lifecycleChangedIdentities(identities)
+    }
   }
 }